Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js

Issue 2389883003: DevTools: hoist debugger paused reason to top (Closed)
Patch Set: address comments; new widget Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
index d83b72d604334f666186c9c5e7ce7044c38b10a3..b7236878a296e8da4e224fed4008310b65eb15b2 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js
@@ -50,6 +50,7 @@ WebInspector.SourcesPanel = function()
this._debugToolbar = this._createDebugToolbar();
this._debugToolbarDrawer = this._createDebugToolbarDrawer();
+ this._debuggerPausedMessage = new WebInspector.DebuggerPausedMessage();
const initialDebugSidebarWidth = 225;
this._splitWidget = new WebInspector.SplitWidget(true, true, "sourcesPanelSplitViewState", initialDebugSidebarWidth);
@@ -93,7 +94,7 @@ WebInspector.SourcesPanel = function()
WebInspector.moduleSetting("sidebarPosition").addChangeListener(this._updateSidebarPosition.bind(this));
this._updateSidebarPosition();
- this._updateDebuggerButtons();
+ this._updateDebuggerButtonsAndStatus();
this._pauseOnExceptionEnabledChanged();
WebInspector.moduleSetting("pauseOnExceptionEnabled").addChangeListener(this._pauseOnExceptionEnabledChanged, this);
@@ -268,7 +269,7 @@ WebInspector.SourcesPanel.prototype = {
_showDebuggerPausedDetails: function(details)
{
this._paused = true;
- this._updateDebuggerButtons();
+ this._updateDebuggerButtonsAndStatus();
WebInspector.context.setFlavor(WebInspector.DebuggerPausedDetails, details);
this._toggleDebuggerSidebarButton.setEnabled(false);
window.focus();
@@ -299,7 +300,7 @@ WebInspector.SourcesPanel.prototype = {
if (WebInspector.context.flavor(WebInspector.Target) !== target)
return;
- this._updateDebuggerButtons();
+ this._updateDebuggerButtonsAndStatus();
},
/**
@@ -452,7 +453,7 @@ WebInspector.SourcesPanel.prototype = {
this._debugToolbarDrawer.classList.toggle("expanded", enabled);
},
- _updateDebuggerButtons: function()
+ _updateDebuggerButtonsAndStatus: function()
{
var currentTarget = WebInspector.context.flavor(WebInspector.Target);
var currentDebuggerModel = WebInspector.DebuggerModel.fromTarget(currentTarget);
@@ -474,12 +475,15 @@ WebInspector.SourcesPanel.prototype = {
this._stepIntoAction.setEnabled(false);
this._stepOutAction.setEnabled(false);
}
+
+ var details = currentDebuggerModel && currentDebuggerModel.debuggerPausedDetails();
+ this._debuggerPausedMessage.render(details);
},
_clearInterface: function()
{
this._sourcesView.clearCurrentExecutionLine();
- this._updateDebuggerButtons();
+ this._updateDebuggerButtonsAndStatus();
WebInspector.context.setFlavor(WebInspector.DebuggerPausedDetails, null);
if (this._switchToPausedTargetTimeout)
@@ -1061,6 +1065,7 @@ WebInspector.SourcesPanel.prototype = {
this._sidebarPaneStack = WebInspector.viewManager.createStackLocation(this._revealDebuggerSidebar.bind(this));
this._sidebarPaneStack.widget().element.classList.add("overflow-auto");
this._sidebarPaneStack.widget().show(vbox.element);
+ this._debuggerPausedMessage.show(this._sidebarPaneStack.widget().element);
vbox.element.appendChild(this._debugToolbar.element);
if (this._threadsSidebarPane)

Powered by Google App Engine
This is Rietveld 408576698