Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 2389873002: Change update-w3c-test-expectations to only rebaseline existing tests. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
jsbell, jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change update-w3c-test-expectations to only rebaseline existing tests. In this CL: - Extract a method get_modified_existing_tests which outputs warnings for tests that don't exist. - In get_modified_existing_tests, when invoking git diff, add --diff-filter so that tests that don't exist shouldn't be gotten in the first place. - Update tests and expand test coverage. BUG=649691 Committed: https://crrev.com/c4e50671c1d6124c8cc4b315f9308a365da79df4 Cr-Commit-Position: refs/heads/master@{#423227}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Sort imports, fix grammar issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -28 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py View 1 4 chunks +36 lines, -20 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations_unittest.py View 3 chunks +55 lines, -8 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
qyearsley
4 years, 2 months ago (2016-10-03 17:30:48 UTC) #2
jsbell
lgtm with nits https://codereview.chromium.org/2389873002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py (right): https://codereview.chromium.org/2389873002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py#newcode351 third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py:351: A pair: A set of tests ...
4 years, 2 months ago (2016-10-04 23:43:34 UTC) #5
qyearsley
https://codereview.chromium.org/2389873002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py File third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py (right): https://codereview.chromium.org/2389873002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py#newcode351 third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py:351: A pair: A set of tests to be rebaselined, ...
4 years, 2 months ago (2016-10-05 17:20:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389873002/20001
4 years, 2 months ago (2016-10-05 17:21:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-05 18:26:50 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 18:31:00 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c4e50671c1d6124c8cc4b315f9308a365da79df4
Cr-Commit-Position: refs/heads/master@{#423227}

Powered by Google App Engine
This is Rietveld 408576698