Add fuzz executable to GN

Add fuzz executable to GN

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2389853002

Committed: https://skia.googlesource.com/skia/+/14f984bc6bdb4327c3f577b7ccbc61a710443288

[kjlubick, 2016-10-03 16:52:37]

Description was changed from

==========
Add fuzz executable to GN

BUG=skia:
==========

to

==========
Add fuzz executable to GN

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2389853002
==========

[kjlubick, 2016-10-03 17:31:53]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, mtklein@google.com

[mtklein_C, 2016-10-03 17:39:38]

mtklein@chromium.org changed reviewers:
+ mtklein@chromium.org

[mtklein_C, 2016-10-03 17:39:39]

https://codereview.chromium.org/2389853002/diff/20001/fuzz/FuzzParsePath.cpp
File fuzz/FuzzParsePath.cpp (right):

https://codereview.chromium.org/2389853002/diff/20001/fuzz/FuzzParsePath.cpp#...
fuzz/FuzzParsePath.cpp:32: bool _gEasy = false;  // set to true while debugging
to suppress unusual whitespace
The author of this fuzz probably meant to write

   static bool gEasy = false;

here.  That'll fix the linker error.

He also probably meant that for gLegal (static const struct Legal ...) and
gWhitespace (static const char gWhitespace[] = ...)

That same author probably also meant to make his globals static in
random_parse_path too, but we only need to change one file to make this work. 
:)

[kjlubick, 2016-10-03 18:05:45]

https://codereview.chromium.org/2389853002/diff/20001/fuzz/FuzzParsePath.cpp
File fuzz/FuzzParsePath.cpp (right):

https://codereview.chromium.org/2389853002/diff/20001/fuzz/FuzzParsePath.cpp#...
fuzz/FuzzParsePath.cpp:32: bool _gEasy = false;  // set to true while debugging
to suppress unusual whitespace
On 2016/10/03 at 17:39:39, mtklein_C wrote:
> The author of this fuzz probably meant to write
> 
>    static bool gEasy = false;
> 
> here.  That'll fix the linker error.
> 
> He also probably meant that for gLegal (static const struct Legal ...) and
gWhitespace (static const char gWhitespace[] = ...)
> 
> That same author probably also meant to make his globals static in
random_parse_path too, but we only need to change one file to make this work. 
:)

Thanks for the tip.  Done.

[mtklein_C, 2016-10-03 18:09:40]

https://codereview.chromium.org/2389853002/diff/40001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2389853002/diff/40001/BUILD.gn#newcode1000
BUILD.gn:1000: deps = [
Seems like deps could be as small as

deps = [
  ":flags",
  ":skia",
]

What's the deal with all the rest?

[kjlubick, 2016-10-03 18:15:07]

On 2016/10/03 at 18:09:40, mtklein wrote:
> https://codereview.chromium.org/2389853002/diff/40001/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2389853002/diff/40001/BUILD.gn#newcode1000
> BUILD.gn:1000: deps = [
> Seems like deps could be as small as
> 
> deps = [
>   ":flags",
>   ":skia",
> ]
> 
> What's the deal with all the rest?

I wasn't sure what to put, so I had just thrown in everything dm used.  Also,
libpng seemed tempting because we fuzz codecs and I wasn't sure if I needed to
bring it in.  It seems to compile and run with just the two you suggested so I
trimmed it down to that.

[mtklein_C, 2016-10-03 18:19:33]

lgtm

The general idea is deps should list what you use directly, and let the things
you use pull in their own dependencies transitively.

[kjlubick, 2016-10-03 18:30:59]

The CQ bit was checked by kjlubick@google.com

[commit-bot: I haz the power, 2016-10-03 18:31:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 18:49:46]

Description was changed from

==========
Add fuzz executable to GN

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2389853002
==========

to

==========
Add fuzz executable to GN

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2389853002

Committed:
https://skia.googlesource.com/skia/+/14f984bc6bdb4327c3f577b7ccbc61a710443288
==========

[commit-bot: I haz the power, 2016-10-03 18:49:47]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/14f984bc6bdb4327c3f577b7ccbc61a710443288