Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(831)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2389833002: Update recommendations for HTTP server packages (Closed)

Created:
4 years, 2 months ago by kevmoo
Modified:
4 years, 2 months ago
Reviewers:
nweiz, dgrove
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M sdk/lib/io/http.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/io.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
kevmoo
4 years, 2 months ago (2016-10-03 16:25:01 UTC) #2
dgrove
On 2016/10/03 16:25:01, kevmoo wrote: LGTM after minor problem fixed.
4 years, 2 months ago (2016-10-06 04:11:54 UTC) #4
kevmoo
On 2016/10/06 04:11:54, dgrove wrote: > On 2016/10/03 16:25:01, kevmoo wrote: > > LGTM after ...
4 years, 2 months ago (2016-10-06 04:13:17 UTC) #5
dgrove
https://codereview.chromium.org/2389833002/diff/1/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/2389833002/diff/1/sdk/lib/io/http.dart#newcode152 sdk/lib/io/http.dart:152: * * The [self](https://pub.dartlang.org/packages/shelf) shelf
4 years, 2 months ago (2016-10-06 04:14:09 UTC) #6
kevmoo
https://codereview.chromium.org/2389833002/diff/1/sdk/lib/io/http.dart File sdk/lib/io/http.dart (right): https://codereview.chromium.org/2389833002/diff/1/sdk/lib/io/http.dart#newcode152 sdk/lib/io/http.dart:152: * * The [self](https://pub.dartlang.org/packages/shelf) On 2016/10/06 04:14:09, dgrove wrote: ...
4 years, 2 months ago (2016-10-06 04:16:26 UTC) #7
kevmoo
Committed patchset #2 (id:20001) manually as 9d9858fa7e383d72a972b5ef75a0e743c9ec7c3f (presubmit successful).
4 years, 2 months ago (2016-10-06 04:16:43 UTC) #9
nweiz
4 years, 2 months ago (2016-10-06 19:46:03 UTC) #10
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698