Issue 238983002: Let revision script add commit dates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 238983002: Let revision script add commit dates. (Closed)

Created:
6 years, 8 months ago by Michael Achenbach

Modified:
6 years, 8 months ago

Reviewers:
Jarin, Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Let revision script add commit dates. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20763

Patch Set 2 : Review. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	tools/push-to-trunk/releases.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	tools/push-to-trunk/test_scripts.py	View	1	4 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with comment. Thanks! https://codereview.chromium.org/238983002/diff/1/tools/push-to-trunk/releases.py File tools/push-to-trunk/releases.py (right): https://codereview.chromium.org/238983002/diff/1/tools/push-to-trunk/releases.py#newcode172 tools/push-to-trunk/releases.py:172: "date": self.GitLog(n=1, format="%cd", git_hash=git_hash), I'd ...

6 years, 8 months ago (2014-04-15 11:56:11 UTC) #2

Michael Achenbach

On 2014/04/15 11:56:11, Jakob wrote: > LGTM with comment. Thanks! > > https://codereview.chromium.org/238983002/diff/1/tools/push-to-trunk/releases.py > File ...

6 years, 8 months ago (2014-04-15 12:00:10 UTC) #3

Michael Achenbach

6 years, 8 months ago (2014-04-15 12:01:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20763 (presubmit successful).

Expand Messages | Collapse Messages

Issue 238983002: Let revision script add commit dates. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Review. #

Messages