third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc - Issue 2389823003: Fix incorrectly calculated content_size for fragments that create new FC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

Issue 2389823003: Fix incorrectly calculated content_size for fragments that create new FC (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

index f7ef2e236c9daf7dfb89efc16267fb26051ef9a9..b8730dedb9db1604179e9ed73c4f08cdd77d03c8 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.cc

@@ -66,6 +66,11 @@ NGFragmentBuilder& NGFragmentBuilder::SetMarginStrutBlockEnd(

return *this;

}

+NGFragmentBuilder& NGFragmentBuilder::ClearMarginStrut() {

+ margin_strut_ = {};

+ return *this;

NGPhysicalFragment* NGFragmentBuilder::ToFragment() {

// TODO(layout-ng): Support text fragments

DCHECK_EQ(type_, NGPhysicalFragmentBase::FragmentBox);