third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc - Issue 2389823003: Fix incorrectly calculated content_size for fragments that create new FC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

Issue 2389823003: Fix incorrectly calculated content_size for fragments that create new FC (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc ('K') | « third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_fragment_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

index 06f038681ee59fafcf793579b9b692d613382b66..eab90a52caced537c6467dc1cea764f260a57d62 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

@@ -160,7 +160,7 @@ TEST_F(NGBlockLayoutAlgorithmTest, CollapsingMarginsCase1) {

space->SetIsNewFormattingContext(true);

NGPhysicalFragment* frag = RunBlockLayoutAlgorithm(space, div1);

- EXPECT_EQ(NGMarginStrut({LayoutUnit(kDiv1MarginTop)}), frag->MarginStrut());

+ EXPECT_EQ(NGMarginStrut({LayoutUnit()}), frag->MarginStrut());

ASSERT_EQ(frag->Children().size(), 1UL);

const NGPhysicalFragmentBase* div2_fragment = frag->Children()[0];

EXPECT_EQ(NGMarginStrut({LayoutUnit(kDiv2MarginTop)}),