third_party/WebKit/Source/core/layout/ng/ng_units.h - Issue 2389823003: Fix incorrectly calculated content_size for fragments that create new FC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_units.h

Issue 2389823003: Fix incorrectly calculated content_size for fragments that create new FC (Closed)

Patch Set: Regroup the code to put together the Collapsing Margins logic for NewFormattingContext's fragments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_units.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_units.h b/third_party/WebKit/Source/core/layout/ng/ng_units.h

index 615132b38d3e9d83512eed927d29da067d82fbb2..4554182a548e8305ed0cecbd2d60639cd8cb98b3 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_units.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_units.h

@@ -139,11 +139,15 @@ struct CORE_EXPORT NGMarginStrut {

LayoutUnit negative_margin_block_start;

LayoutUnit negative_margin_block_end;

+ LayoutUnit BlockEndSum() const;

void AppendMarginBlockStart(const LayoutUnit& value);

void AppendMarginBlockEnd(const LayoutUnit& value);

void SetMarginBlockStart(const LayoutUnit& value);

void SetMarginBlockEnd(const LayoutUnit& value);

+ bool IsEmpty() const;

String ToString() const;

bool operator==(const NGMarginStrut& other) const;