Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 2389813003: Some cleanup of the histogram guide. Mainly formatting fixes. (Closed)

Created:
4 years, 2 months ago by rkaplow
Modified:
4 years, 2 months ago
Reviewers:
Mark P
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Some cleanup of the histogram guide. Mainly formatting fixes. Can see current guide at: https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#Revising-Histograms Largest change is removal of the guide on exact linear histogram, I think it is less important to give guidance now there is an explicit macro. BUG= Committed: https://crrev.com/6dfcb893913ccd2bd6cf4f9e07a4e156aaa6cb27 Cr-Commit-Position: refs/heads/master@{#422779}

Patch Set 1 #

Total comments: 4

Patch Set 2 : mpearson #

Patch Set 3 : remove ws #

Patch Set 4 : adding mark and I as owners #

Patch Set 5 : revert owner change - was in wrong CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -31 lines) Patch
M tools/metrics/histograms/README.md View 1 2 6 chunks +18 lines, -31 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
rkaplow
4 years, 2 months ago (2016-10-03 21:54:13 UTC) #3
Mark P
lgtm with comments Thanks for doing this. --mark https://codereview.chromium.org/2389813003/diff/1/tools/metrics/histograms/README.md File tools/metrics/histograms/README.md (right): https://codereview.chromium.org/2389813003/diff/1/tools/metrics/histograms/README.md#newcode88 tools/metrics/histograms/README.md:88: for ...
4 years, 2 months ago (2016-10-03 22:00:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389813003/40001
4 years, 2 months ago (2016-10-04 13:55:49 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-04 14:04:46 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6dfcb893913ccd2bd6cf4f9e07a4e156aaa6cb27 Cr-Commit-Position: refs/heads/master@{#422779}
4 years, 2 months ago (2016-10-04 14:07:23 UTC) #11
rkaplow
4 years, 2 months ago (2016-10-04 15:40:33 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/2389813003/diff/1/tools/metrics/histograms/RE...
File tools/metrics/histograms/README.md (right):

https://codereview.chromium.org/2389813003/diff/1/tools/metrics/histograms/RE...
tools/metrics/histograms/README.md:88: for larger numbers.  The macros default
to 50 buckets which is appropriate for
On 2016/10/03 22:00:47, Mark P wrote:
> some default to 100; that's why I just wishy-washy words.  Not sure if this is
> important.

ok, just added a note.

https://codereview.chromium.org/2389813003/diff/1/tools/metrics/histograms/RE...
tools/metrics/histograms/README.md:97: Test your histograms using
*chrome://histograms*.  Make sure they're being
On 2016/10/03 22:00:47, Mark P wrote:
> *chrome://histograms*
> will this make a link?

No - this just turns it italic. I'm not sure how to do a non http link, I
couldn't find any examples, and it may not even be possible. I figured  just
italic would be good enough.

Powered by Google App Engine
This is Rietveld 408576698