Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2389803006: Revert of Fix task manager's default sizing. (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
sky, Evan Stade
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix task manager's default sizing. (patchset #6 id:100001 of https://codereview.chromium.org/2344703002/ ) Reason for revert: On Linux, the task manager window self expands and gets wider and wiser. Original issue's description: > Fix task manager's default sizing. > > Set default width based on contents rather than hardcoding a value (which happened to be too small once we adjusted outer padding for the dialog). > > BUG=614317 > > Committed: https://crrev.com/6678470d3169979d811eec56e7cdea668ab751c1 > Cr-Commit-Position: refs/heads/master@{#422893} TBR=sky@chromium.org,estade@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=614317 Committed: https://crrev.com/cc9948e8ed03ea9230047ced2e8167afb873c7a4 Cr-Commit-Position: refs/heads/master@{#423023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -27 lines) Patch
M chrome/browser/ui/views/task_manager_view.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/task_manager_view.cc View 1 chunk +1 line, -10 lines 0 comments Download
M ui/views/controls/scroll_view.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M ui/views/controls/table/table_view.h View 1 chunk +6 lines, -2 lines 0 comments Download
M ui/views/controls/table/table_view.cc View 3 chunks +24 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
Created Revert of Fix task manager's default sizing.
4 years, 2 months ago (2016-10-05 00:39:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389803006/1
4 years, 2 months ago (2016-10-05 00:40:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 00:41:13 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 00:50:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc9948e8ed03ea9230047ced2e8167afb873c7a4
Cr-Commit-Position: refs/heads/master@{#423023}

Powered by Google App Engine
This is Rietveld 408576698