Convert LayoutTests/svg/dom/SVGAnimatedEnumeration*.html js-tests.js to testharness.js based tests.

Convert LayoutTests/svg/dom/SVGAnimatedEnumeration*.html js-tests.js to testharness.js based tests.

BUG=636710
Committed: https://crrev.com/a2f382d07bfecb3b146a728ce31d2a4031e2c890
Cr-Commit-Position: refs/heads/master@{#423437}

[Shanmuga Pandi, 2016-10-04 06:27:42]

shanmuga.m@samsung.com changed reviewers:
+ srirama.m@samsung.com

[Shanmuga Pandi, 2016-10-04 06:27:42]

PTAL!!

[Srirama, 2016-10-04 09:32:05]

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html
(right):

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html:13:
assert_equals(clipPathElement.clipPathUnits.toString(), "[object
SVGAnimatedEnumeration]");
please try same thing here, to remove toString conversion

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html
(right):

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html:13:
assert_equals(feFuncRElement.type.toString(), "[object
SVGAnimatedEnumeration]");
same here as well

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html
(right):

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html:13:
assert_equals(feBlendElement.mode.toString(), "[object
SVGAnimatedEnumeration]");
same here also.

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html
(right):

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html:13:
assert_equals(feColorMatrixElement.type.toString(), "[object
SVGAnimatedEnumeration]");
ditto

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html
(right):

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html:13:
assert_equals(feCompositeElement.operator.toString(), "[object
SVGAnimatedEnumeration]");
ditto

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html
(right):

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html:13:
assert_equals(feConvolveMatrixElement.edgeMode.toString(), "[object
SVGAnimatedEnumeration]");
ditto

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration.html (right):

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration.html:12:
assert_equals(clipPathElement.clipPathUnits.toString(), "[object
SVGAnimatedEnumeration]");
can we remove toString conversion and check directly with object may be using
instanceof operator ?

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration.html:29:
assert_equals(clipPathElement.clipPathUnits.baseVal = '1',
SVGUnitTypes.SVG_UNIT_TYPE_USERSPACEONUSE.toString());
may be split it into assignment and then check for assert.

[Shanmuga Pandi, 2016-10-05 06:53:10]

PTAL!

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html
(right):

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGClipPathElement.html:13:
assert_equals(clipPathElement.clipPathUnits.toString(), "[object
SVGAnimatedEnumeration]");
On 2016/10/04 09:32:04, Srirama_OnBizTrip_till_26OCT wrote:
> please try same thing here, to remove toString conversion

Done.

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html
(right):

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement.html:13:
assert_equals(feFuncRElement.type.toString(), "[object
SVGAnimatedEnumeration]");
On 2016/10/04 09:32:04, Srirama_OnBizTrip_till_26OCT wrote:
> same here as well

Done.

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html
(right):

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement.html:13:
assert_equals(feBlendElement.mode.toString(), "[object
SVGAnimatedEnumeration]");
On 2016/10/04 09:32:04, Srirama_OnBizTrip_till_26OCT wrote:
> same here also.

Done.

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html
(right):

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement.html:13:
assert_equals(feColorMatrixElement.type.toString(), "[object
SVGAnimatedEnumeration]");
On 2016/10/04 09:32:04, Srirama_OnBizTrip_till_26OCT wrote:
> ditto

Done.

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html
(right):

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement.html:13:
assert_equals(feCompositeElement.operator.toString(), "[object
SVGAnimatedEnumeration]");
On 2016/10/04 09:32:04, Srirama_OnBizTrip_till_26OCT wrote:
> ditto

Done.

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html
(right):

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement.html:13:
assert_equals(feConvolveMatrixElement.edgeMode.toString(), "[object
SVGAnimatedEnumeration]");
On 2016/10/04 09:32:05, Srirama_OnBizTrip_till_26OCT wrote:
> ditto

Done.

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration.html (right):

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration.html:12:
assert_equals(clipPathElement.clipPathUnits.toString(), "[object
SVGAnimatedEnumeration]");
On 2016/10/04 09:32:05, Srirama_OnBizTrip_till_26OCT wrote:
> can we remove toString conversion and check directly with object may be using
> instanceof operator ?

Done.

https://codereview.chromium.org/2389803004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/dom/SVGAnimatedEnumeration.html:29:
assert_equals(clipPathElement.clipPathUnits.baseVal = '1',
SVGUnitTypes.SVG_UNIT_TYPE_USERSPACEONUSE.toString());
On 2016/10/04 09:32:05, Srirama_OnBizTrip_till_26OCT wrote:
> may be split it into assignment and then check for assert.

Done.

[Srirama, 2016-10-05 11:26:52]

srirama.m@samsung.com changed reviewers:
+ fs@opera.com

[Srirama, 2016-10-05 11:26:53]

lgtm

+fs

[fs, 2016-10-05 13:28:41]

lgtm

[Shanmuga Pandi, 2016-10-06 04:26:07]

The CQ bit was checked by shanmuga.m@samsung.com

[commit-bot: I haz the power, 2016-10-06 04:26:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 05:14:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 05:16:30]

Description was changed from

==========
Convert LayoutTests/svg/dom/SVGAnimatedEnumeration*.html js-tests.js to
testharness.js based tests.

BUG=636710
==========

to

==========
Convert LayoutTests/svg/dom/SVGAnimatedEnumeration*.html js-tests.js to
testharness.js based tests.

BUG=636710

Committed: https://crrev.com/a2f382d07bfecb3b146a728ce31d2a4031e2c890
Cr-Commit-Position: refs/heads/master@{#423437}
==========

[commit-bot: I haz the power, 2016-10-06 05:16:31]

Patchset 2 (id:??) landed as
https://crrev.com/a2f382d07bfecb3b146a728ce31d2a4031e2c890
Cr-Commit-Position: refs/heads/master@{#423437}