Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: pkg/polymer/test/run_all.dart

Issue 23898009: Switch polymer's build.dart to use the new linter. This CL does the following (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/polymer/test/run_all.dart
diff --git a/pkg/polymer/test/run_all.dart b/pkg/polymer/test/run_all.dart
index 6191492f729bdc8f4152f13853dd7a1f7e505209..ba46ba155ebf3e4a59b87f88a2bf69d0197d51db 100644
--- a/pkg/polymer/test/run_all.dart
+++ b/pkg/polymer/test/run_all.dart
@@ -11,10 +11,7 @@ library run_impl;
import 'dart:io';
import 'package:unittest/compact_vm_config.dart';
import 'package:unittest/unittest.dart';
-import 'package:polymer/testing/content_shell_test.dart';
-import 'compiler_test.dart' as compiler_test;
-import 'css_test.dart' as css_test;
import 'transform/all_phases_test.dart' as all_phases_test;
import 'transform/code_extractor_test.dart' as code_extractor_test;
import 'transform/import_inliner_test.dart' as import_inliner_test;
@@ -36,8 +33,6 @@ main() {
}
addGroup('linter_test.dart', linter_test.main);
- addGroup('compiler_test.dart', compiler_test.main);
- addGroup('css_test.dart', css_test.main);
addGroup('utils_test.dart', utils_test.main);
addGroup('transform/code_extractor_test.dart', code_extractor_test.main);
addGroup('transform/import_inliner_test.dart', import_inliner_test.main);
@@ -45,24 +40,4 @@ main() {
addGroup('transform/polyfill_injector_test.dart',
polyfill_injector_test.main);
addGroup('transform/all_phases_test.dart', all_phases_test.main);
-
- endToEndTests('data/unit/web', 'data/out');
-
- // Note: if you're adding more render test suites, make sure to update run.sh
- // as well for convenient baseline diff/updating.
-
- // TODO(jmesserly): figure out why this fails in content_shell but works in
- // Dartium and Firefox when using the ShadowDOM polyfill.
- exampleTest('../example/component/news', ['--no-shadowdom']..addAll(args));
-}
-
-void exampleTest(String path, [List args]) {
- // TODO(sigmund): renderTests currently contatenates [path] with the out
- // folder. This can be a problem with relative paths that go up (like todomvc
- // above, which has '../../../'). If we continue running tests with
- // test/run.sh, we should fix this. For now we work around this problem by
- // using a long path 'data/out/example/test'. That way we avoid dumping output
- // in the source-tree.
- renderTests(path, '$path/test', '$path/test/expected',
- 'data/out/example/test', arguments: args);
}

Powered by Google App Engine
This is Rietveld 408576698