pkg/polymer/test/transform/polyfill_injector_test.dart - Issue 23898009: Switch polymer's build.dart to use the new linter. This CL does the following

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer/test/transform/polyfill_injector_test.dart

Issue 23898009: Switch polymer's build.dart to use the new linter. This CL does the following (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: addressing john comments (part 2) - renamed files Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/polymer/test/transform/polyfill_injector_test.dart

diff --git a/pkg/polymer/test/transform/polyfill_injector_test.dart b/pkg/polymer/test/transform/polyfill_injector_test.dart

index e8bbb8954944b6f8452192beecfba813796917ba..8bb92edc7cc2ec6de863746aaac5bd0f1d68afd2 100644

--- a/pkg/polymer/test/transform/polyfill_injector_test.dart

+++ b/pkg/polymer/test/transform/polyfill_injector_test.dart

@@ -4,21 +4,23 @@

library polymer.test.transform.polyfill_injector_test;

-import 'package:polymer/src/transform.dart';

+import 'package:polymer/src/transform/common.dart';

+import 'package:polymer/src/transform/polyfill_injector.dart';

import 'package:unittest/compact_vm_config.dart';

import 'common.dart';

void main() {

useCompactVMConfiguration();

+ var phases = [[new PolyfillInjector(new TransformOptions())]];

- testPhases('no changes', [[new PolyfillInjector()]], {

+ testPhases('no changes', phases, {

'a|web/test.html': '<!DOCTYPE html><html></html>',

}, {

'a|web/test.html': '<!DOCTYPE html><html></html>',

});

- testPhases('no changes under lib ', [[new PolyfillInjector()]], {

+ testPhases('no changes under lib ', phases, {

'a|lib/test.html':

'<!DOCTYPE html><html><head></head><body>'

'<script type="application/dart" src="a.dart"></script>',

@@ -28,7 +30,7 @@ void main() {

'<script type="application/dart" src="a.dart"></script>',

});

- testPhases('with some script', [[new PolyfillInjector()]], {

+ testPhases('with some script', phases, {

'a|web/test.html':

'<!DOCTYPE html><html><head></head><body>'

'<script type="application/dart" src="a.dart"></script>',

@@ -40,7 +42,7 @@ void main() {

'</body></html>',

});

- testPhases('interop/shadow dom already present', [[new PolyfillInjector()]], {

+ testPhases('interop/shadow dom already present', phases, {

'a|web/test.html':

'<!DOCTYPE html><html><head></head><body>'

'<script type="application/dart" src="a.dart"></script>'

« no previous file with comments | « pkg/polymer/test/transform/import_inliner_test.dart ('k') | pkg/polymer/test/transform/script_compactor_test.dart » ('j') | no next file with comments »