pkg/polymer/test/transform/code_extractor_test.dart - Issue 23898009: Switch polymer's build.dart to use the new linter. This CL does the following

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer/test/transform/code_extractor_test.dart

Issue 23898009: Switch polymer's build.dart to use the new linter. This CL does the following (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: addressing john comments (part 2) - renamed files Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/polymer/test/transform/code_extractor_test.dart

diff --git a/pkg/polymer/test/transform/code_extractor_test.dart b/pkg/polymer/test/transform/code_extractor_test.dart

index 72aefb94ffaf35715c2bd81e8aabe41b745d6862..2f71869ace74761477192b3fa4911cb9b008c330 100644

--- a/pkg/polymer/test/transform/code_extractor_test.dart

+++ b/pkg/polymer/test/transform/code_extractor_test.dart

@@ -5,21 +5,22 @@

library polymer.test.transform.code_extractor_test;

import 'package:polymer/src/transform/code_extractor.dart';

+import 'package:polymer/src/transform/common.dart';

import 'package:unittest/compact_vm_config.dart';

import 'common.dart';

void main() {

useCompactVMConfiguration();

+ var phases = [[new InlineCodeExtractor(new TransformOptions())]];

- testPhases('no changes', [[new InlineCodeExtractor()]], {

+ testPhases('no changes', phases, {

'a|web/test.html': '<!DOCTYPE html><html></html>',

}, {

'a|web/test.html': '<!DOCTYPE html><html></html>',

});

- testPhases('single script, no library in script',

- [[new InlineCodeExtractor()]], {

+ testPhases('single script, no library in script', phases, {

'a|web/test.html':

'<!DOCTYPE html><html><head>'

'<script type="application/dart">main() { }</script>',

@@ -33,7 +34,7 @@ void main() {

'library web_test_html_0;\nmain() { }',

});

- testPhases('single script, with library', [[new InlineCodeExtractor()]], {

+ testPhases('single script, with library', phases, {

'a|web/test.html':

'<!DOCTYPE html><html><head>'

'<script type="application/dart">library f;\nmain() { }</script>',

@@ -47,8 +48,7 @@ void main() {

'library f;\nmain() { }',

});

- testPhases('under lib/ directory also transformed',

- [[new InlineCodeExtractor()]], {

+ testPhases('under lib/ directory also transformed', phases, {

'a|lib/test.html':

'<!DOCTYPE html><html><head>'

'<script type="application/dart">library f;\nmain() { }</script>',

@@ -62,7 +62,7 @@ void main() {

'library f;\nmain() { }',

});

- testPhases('multiple scripts', [[new InlineCodeExtractor()]], {

+ testPhases('multiple scripts', phases, {

'a|web/test.html':

'<!DOCTYPE html><html><head>'

'<script type="application/dart">library a1;\nmain1() { }</script>'

@@ -81,7 +81,7 @@ void main() {

'library a2;\nmain2() { }',

});

- testPhases('multiple deeper scripts', [[new InlineCodeExtractor()]], {

+ testPhases('multiple deeper scripts', phases, {

'a|web/test.html':

'<!DOCTYPE html><html><head>'

'<script type="application/dart">main1() { }</script>'

« no previous file with comments | « pkg/polymer/test/transform/all_phases_test.dart ('k') | pkg/polymer/test/transform/import_inliner_test.dart » ('j') | no next file with comments »