Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3038)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js

Issue 2389793002: Don't read aria attribute changes on editables. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
index 550398551a36c7b93142193392f7fbcf8717dcab..7e9cfb133a9e1704b81dd7fa88fbe0efd6880fa5 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js
@@ -46,7 +46,7 @@ DesktopAutomationHandler = function(node) {
var e = EventType;
this.addListener_(e.activedescendantchanged, this.onActiveDescendantChanged);
this.addListener_(e.alert, this.onAlert);
- this.addListener_(e.ariaAttributeChanged, this.onEventIfInRange);
+ this.addListener_(e.ariaAttributeChanged, this.onAriaAttributeChanged);
this.addListener_(e.autocorrectionOccured, this.onEventIfInRange);
this.addListener_(e.checkedStateChanged, this.onCheckedStateChanged);
this.addListener_(e.childrenChanged, this.onActiveDescendantChanged);
@@ -182,6 +182,15 @@ DesktopAutomationHandler.prototype = {
/**
* @param {!AutomationEvent} evt
*/
+ onAriaAttributeChanged: function(evt) {
+ if (evt.target.state.editable)
+ return;
+ this.onEventIfInRange(evt);
+ },
+
+ /**
+ * @param {!AutomationEvent} evt
+ */
onHover: function(evt) {
if (ChromeVoxState.instance.currentRange &&
evt.target == ChromeVoxState.instance.currentRange.start.node)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698