Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2389793002: Don't read aria attribute changes on editables. (Closed)

Created:
4 years, 2 months ago by David Tseng
Modified:
4 years, 2 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't read aria attribute changes on editables. By typing into an editable, aria attributes do often change (e.g. aria label). Read the attributes on demand (e.g. when a user navigates back to the control or requests a summary of the current element). CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation BUG=621324 Committed: https://crrev.com/5d1bf66ecc361012770c73136a5bb22a6a22176f Cr-Commit-Position: refs/heads/master@{#422612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/desktop_automation_handler.js View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
David Tseng
4 years, 2 months ago (2016-10-03 15:54:10 UTC) #4
dmazzoni
lgtm
4 years, 2 months ago (2016-10-03 18:28:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389793002/1
4 years, 2 months ago (2016-10-03 22:39:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 00:07:53 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 00:09:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d1bf66ecc361012770c73136a5bb22a6a22176f
Cr-Commit-Position: refs/heads/master@{#422612}

Powered by Google App Engine
This is Rietveld 408576698