Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 2389783002: Make AudioRendererMixerInput::SwitchOutputDevice to work correctly even if it has not been initiali… (Closed)

Created:
4 years, 2 months ago by o1ka
Modified:
4 years, 2 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, Dale Curtis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make AudioRendererMixerInput::SwitchOutputDevice to work correctly even if it has not been initialized yet. + unit test fixes. BUG=627901 Committed: https://crrev.com/3cccabe93fddbe0c72045b38873a362b5cf11ca0 Cr-Commit-Position: refs/heads/master@{#422816}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -27 lines) Patch
M media/base/audio_renderer_mixer_input.cc View 1 chunk +24 lines, -13 lines 0 comments Download
M media/base/audio_renderer_mixer_input_unittest.cc View 18 chunks +89 lines, -14 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
o1ka
PTAL
4 years, 2 months ago (2016-10-03 14:45:29 UTC) #2
Guido Urdaneta
lgtm
4 years, 2 months ago (2016-10-04 09:24:39 UTC) #3
o1ka
chcunningham@chromium.org: PTAL (need your RS)
4 years, 2 months ago (2016-10-04 10:57:34 UTC) #5
chcunningham
RS LGTM
4 years, 2 months ago (2016-10-04 15:51:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389783002/1
4 years, 2 months ago (2016-10-04 15:57:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 16:02:52 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 16:04:33 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cccabe93fddbe0c72045b38873a362b5cf11ca0
Cr-Commit-Position: refs/heads/master@{#422816}

Powered by Google App Engine
This is Rietveld 408576698