Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h

Issue 2389763003: arc: Fix race when arc package sync service starts. (Closed)
Patch Set: Add Check in case ArcAppListPrefs gets deleted early. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h
diff --git a/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h b/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h
index f235684368cb25790bb8affd466c54d2077b5bea..b07d5e65493c3f09d7c807ca3e135f393476aef4 100644
--- a/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h
+++ b/chrome/browser/ui/app_list/arc/arc_package_sync_data_type_controller.h
@@ -6,8 +6,7 @@
#define CHROME_BROWSER_UI_APP_LIST_ARC_ARC_PACKAGE_SYNC_DATA_TYPE_CONTROLLER_H_
#include "base/macros.h"
-#include "components/arc/common/app.mojom.h"
-#include "components/arc/instance_holder.h"
+#include "chrome/browser/ui/app_list/arc/arc_app_list_prefs.h"
#include "components/prefs/pref_change_registrar.h"
#include "components/sync/driver/data_type_controller.h"
#include "components/sync/driver/ui_data_type_controller.h"
@@ -20,9 +19,8 @@ class SyncClient;
// A UIDataTypeController for arc package sync datatypes, which enables or
// disables these types based on whether ArcAppInstance is ready.
-class ArcPackageSyncDataTypeController
- : public syncer::UIDataTypeController,
- public arc::InstanceHolder<arc::mojom::AppInstance>::Observer {
+class ArcPackageSyncDataTypeController : public syncer::UIDataTypeController,
+ public ArcAppListPrefs::Observer {
public:
// |dump_stack| is called when an unrecoverable error occurs.
ArcPackageSyncDataTypeController(syncer::ModelType type,
@@ -34,10 +32,11 @@ class ArcPackageSyncDataTypeController
// UIDataTypeController override:
bool ReadyForStart() const override;
bool StartModels() override;
+ void StopModels() override;
private:
- // arc::InstanceHolder<arc::mojom::AppInstance>::Observer:
- void OnInstanceReady() override;
+ // ArcAppListPrefs::Observer:
+ void OnPackageListInitialRefreshed() override;
void OnArcEnabledPrefChanged();

Powered by Google App Engine
This is Rietveld 408576698