Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2389753003: Delete unused BluetoothAudioSink code. (Closed)

Created:
4 years, 2 months ago by Rahul Chaturvedi
Modified:
4 years, 2 months ago
Reviewers:
Miao, scheib, ortuno
CC:
chromium-reviews, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete unused BluetoothAudioSink code. The BluetoothAudioSink code does not seem to be used from anywhere. The code is currently just bloat. If we decide in the future to use this code, we can always re-add it back again by reverting this CL. Reviews requested, ortuno@ or scheib@ - OWNERs mcchou@ - original author of the code, hence general review. R=mcchou@chromium.org, ortuno@chromium.org, scheib@chromium.org BUG=None Committed: https://crrev.com/4fbda0de3e3ad67b04414eb5779cbfa8dfff9f8b Cr-Commit-Position: refs/heads/master@{#422730}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2067 lines) Patch
M device/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_adapter.h View 3 chunks +0 lines, -13 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_android.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.h View 2 chunks +0 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_mac.mm View 1 chunk +0 lines, -8 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_unittest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.h View 2 chunks +0 lines, -5 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_win.cc View 1 chunk +0 lines, -8 lines 0 comments Download
D device/bluetooth/bluetooth_audio_sink.h View 1 chunk +0 lines, -132 lines 0 comments Download
D device/bluetooth/bluetooth_audio_sink.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_adapter_bluez.h View 3 chunks +0 lines, -12 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_adapter_bluez.cc View 4 chunks +0 lines, -33 lines 0 comments Download
D device/bluetooth/bluez/bluetooth_audio_sink_bluez.h View 1 chunk +0 lines, -223 lines 0 comments Download
D device/bluetooth/bluez/bluetooth_audio_sink_bluez.cc View 1 chunk +0 lines, -567 lines 0 comments Download
D device/bluetooth/bluez/bluetooth_audio_sink_bluez_unittest.cc View 1 chunk +0 lines, -958 lines 0 comments Download
M device/bluetooth/bluez/bluetooth_bluez_unittest.cc View 5 chunks +0 lines, -30 lines 0 comments Download
M device/bluetooth/test/mock_bluetooth_adapter.h View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Rahul Chaturvedi
4 years, 2 months ago (2016-10-03 22:17:05 UTC) #1
scheib
LGTM
4 years, 2 months ago (2016-10-04 01:54:28 UTC) #2
Miao
lgtm
4 years, 2 months ago (2016-10-04 04:54:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389753003/1
4 years, 2 months ago (2016-10-04 05:52:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 07:33:46 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 07:35:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fbda0de3e3ad67b04414eb5779cbfa8dfff9f8b
Cr-Commit-Position: refs/heads/master@{#422730}

Powered by Google App Engine
This is Rietveld 408576698