Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2389753002: doc.write blocking intervention warning header (Closed)

Created:
4 years, 2 months ago by shivanisha
Modified:
4 years, 2 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, Bryan McQuade, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, jkarlin, loading-reviews_chromium.org, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In cases where doc.write blocking intervention could have applied had it not been a faster connection or a reload, send a warning level intervention header in the GET request: Intervention: <https://www.chromestatus.com/feature/5718547946799104>; ; level="warning" BUG=649082 Committed: https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae Cr-Commit-Position: refs/heads/master@{#423257}

Patch Set 1 #

Patch Set 2 : Rebased till refs/heads/master@{#422406} #

Total comments: 2

Patch Set 3 : Feedback incorporated #

Messages

Total messages: 27 (20 generated)
shivanisha
PTAL, Thanks!
4 years, 2 months ago (2016-10-03 17:11:58 UTC) #13
Nate Chapin
https://codereview.chromium.org/2389753002/diff/40001/third_party/WebKit/Source/core/fetch/FetchContext.h File third_party/WebKit/Source/core/fetch/FetchContext.h (right): https://codereview.chromium.org/2389753002/diff/40001/third_party/WebKit/Source/core/fetch/FetchContext.h#newcode79 third_party/WebKit/Source/core/fetch/FetchContext.h:79: std::pair<AtomicString, AtomicString>&) const; Let's just take a non-const ResourceRequest& ...
4 years, 2 months ago (2016-10-04 20:33:42 UTC) #16
shivanisha
https://codereview.chromium.org/2389753002/diff/40001/third_party/WebKit/Source/core/fetch/FetchContext.h File third_party/WebKit/Source/core/fetch/FetchContext.h (right): https://codereview.chromium.org/2389753002/diff/40001/third_party/WebKit/Source/core/fetch/FetchContext.h#newcode79 third_party/WebKit/Source/core/fetch/FetchContext.h:79: std::pair<AtomicString, AtomicString>&) const; On 2016/10/04 at 20:33:42, Nate Chapin ...
4 years, 2 months ago (2016-10-05 17:11:55 UTC) #19
Nate Chapin
lgtm
4 years, 2 months ago (2016-10-05 18:00:33 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389753002/60001
4 years, 2 months ago (2016-10-05 19:39:53 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 2 months ago (2016-10-05 19:47:26 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 19:51:04 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6be2bff3df41039c4d3e92680b8ebb72f17a45ae
Cr-Commit-Position: refs/heads/master@{#423257}

Powered by Google App Engine
This is Rietveld 408576698