Issue 238973011: Revert "ES6: Add support for Map/Set forEach"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 238973011: Revert "ES6: Add support for Map/Set forEach" (Closed)

Created:
6 years, 8 months ago by adamk

Modified:
6 years, 8 months ago

Reviewers:
arv (Not doing code reviews), Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Revert "ES6: Add support for Map/Set forEach" This reverts https://code.google.com/p/v8/source/detail?r=20823 It broke Windows builds. Will need to find a Windows try bot to figure out why. TBR=mstarzinger@chromium.org,arv@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20824

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+71 lines, -1213 lines)			Patch
M	src/arm/full-codegen-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm64/full-codegen-arm64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/array-iterator.js	View	2 chunks	+10 lines, -5 lines	0 comments	Download
M	src/bootstrapper.cc	View	2 chunks	+16 lines, -27 lines	0 comments	Download
M	src/collection.js	View	5 chunks	+6 lines, -54 lines	0 comments	Download
M	src/contexts.h	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/factory.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/factory.cc	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/macros.py	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/mips/full-codegen-mips.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	14 chunks	+9 lines, -181 lines	0 comments	Download
M	src/objects.cc	View	11 chunks	+20 lines, -261 lines	0 comments	Download
M	src/objects-debug.cc	View	3 chunks	+0 lines, -40 lines	0 comments	Download
M	src/objects-inl.h	View	5 chunks	+0 lines, -48 lines	0 comments	Download
M	src/objects-printer.cc	View	4 chunks	+3 lines, -41 lines	0 comments	Download
M	src/objects-visiting.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/runtime.cc	View	4 chunks	+0 lines, -85 lines	0 comments	Download
M	src/x64/full-codegen-x64.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-ordered-hash-table.cc	View	8 chunks	+0 lines, -84 lines	0 comments	Download
M	test/mjsunit/harmony/collections.js	View	1 chunk	+0 lines, -344 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

adamk

6 years, 8 months ago (2014-04-16 21:19:36 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r20824 (tree was closed).

Expand Messages | Collapse Messages