Minor refactoring to avoid redundant calls to RenderObject::style()

Minor refactoring to avoid redundant calls to RenderObject::style()

We can avoid redundant calls to style() in the api computePreferredLogicalWidths()
by introducing a local variable.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171833

[harpreet.sk, 2014-04-16 09:27:12]

Minor change. Please have a look

[tkent, 2014-04-16 14:11:23]

https://codereview.chromium.org/238973008/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderDeprecatedFlexibleBox.cpp (right):

https://codereview.chromium.org/238973008/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderDeprecatedFlexibleBox.cpp:231: RenderStyle*
styleToUse = style();
I prefer
    RenderStyle& style = *this->style();

[harpreet.sk, 2014-04-16 14:26:51]

https://codereview.chromium.org/238973008/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderDeprecatedFlexibleBox.cpp (right):

https://codereview.chromium.org/238973008/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderDeprecatedFlexibleBox.cpp:231: RenderStyle*
styleToUse = style();
On 2014/04/16 14:11:24, tkent wrote:
> I prefer
>     RenderStyle& style = *this->style();

 
RenderStyle* styleToUse = style();
is already being used at many places say for eg in
RenderBlock::computePreferredLogicalWidths() so i thought i will make it uniform
everywhere. If you want it do it like  
RenderStyle& style = *this->style(); 
i can change it .

[tkent, 2014-04-17 02:12:01]

lgtm

https://codereview.chromium.org/238973008/diff/1/Source/core/rendering/Render...
File Source/core/rendering/RenderDeprecatedFlexibleBox.cpp (right):

https://codereview.chromium.org/238973008/diff/1/Source/core/rendering/Render...
Source/core/rendering/RenderDeprecatedFlexibleBox.cpp:231: RenderStyle*
styleToUse = style();
On 2014/04/16 14:26:52, harpreet.sk wrote:
> On 2014/04/16 14:11:24, tkent wrote:
> > I prefer
> >     RenderStyle& style = *this->style();
> 
>  
> RenderStyle* styleToUse = style();
> is already being used at many places say for eg in
> RenderBlock::computePreferredLogicalWidths() so i thought i will make it
uniform
> everywhere. If you want it do it like  
> RenderStyle& style = *this->style(); 
> i can change it . 

ok, consistency is important.

[commit-bot: I haz the power, 2014-04-17 02:12:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/harpreet.sk@samsung.com/238973008/1

[commit-bot: I haz the power, 2014-04-17 03:17:28]

Change committed as 171833