Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 238973004: LazyInstance should be thread safe by default. (Closed)

Created:
6 years, 8 months ago by mvstanton
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

LazyInstance should be thread safe by default. The only ways we use this class require it, as multiple isolates can race to initialize data structures. This showed up as intermittant failures on nosnap build bots. R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20794

Patch Set 1 : Patch One #

Total comments: 1

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M src/lazy-instance.h View 1 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mvstanton
Hi Hannes, Here is one of the issues to address. PTAL, thx, --Michael ps - ...
6 years, 8 months ago (2014-04-15 15:09:59 UTC) #1
Hannes Payer (out of office)
https://codereview.chromium.org/238973004/diff/20001/src/lazy-instance.h File src/lazy-instance.h (right): https://codereview.chromium.org/238973004/diff/20001/src/lazy-instance.h#newcode178 src/lazy-instance.h:178: // Thank you for making this the default, Satan. ...
6 years, 8 months ago (2014-04-16 07:56:56 UTC) #2
Hannes Payer (out of office)
lgtm
6 years, 8 months ago (2014-04-16 07:57:02 UTC) #3
mvstanton
6 years, 8 months ago (2014-04-16 11:31:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r20794 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698