Handlify Object::GetPrototype and (most) callers.

src/string-stream.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "string-stream.h"
 
 #include "handles-inl.h"
 
 namespace v8 {
 namespace internal {
@@ skipping 484 matching lines @@
     // Unless this is the frame of a built-in function, we should always have
     // the callee function or name on the stack. If we don't, we have a
     // problem or a change of the stack frame layout.
     Add("%o", f);
     Add("/* warning: no JSFunction object or function name found */ ");
   }
 }
 
 
 void StringStream::PrintPrototype(JSFunction* fun, Object* receiver) {
+  Isolate* isolate = fun->GetIsolate();
+  DisallowHeapAllocation no_alloc;
+  HandleScope scope(isolate);
+
   Object* name = fun->shared()->name();
   bool print_name = false;
-  Isolate* isolate = fun->GetIsolate();
-  for (Object* p = receiver;
-       p != isolate->heap()->null_value();
-       p = p->GetPrototype(isolate)) {
+  for (Handle<Object> p(receiver, isolate);
+       !p->IsNull();
+       p = Object::GetPrototype(isolate, p)) {

[Yang, 2014/04/15 13:10:48]

Please don't handlify here.

     if (p->IsJSObject()) {
-      Object* key = JSObject::cast(p)->SlowReverseLookup(fun);
+      Object* key = JSObject::cast(*p)->SlowReverseLookup(fun);
       if (key != isolate->heap()->undefined_value()) {
         if (!name->IsString() ||
             !key->IsString() ||
             !String::cast(name)->Equals(String::cast(key))) {
           print_name = true;
         }
         if (name->IsString() && String::cast(name)->length() == 0) {
           print_name = false;
         }
         name = key;
@@ skipping 33 matching lines @@
 
 // Only grow once to the maximum allowable size.
 char* NoAllocationStringAllocator::grow(unsigned* bytes) {
   ASSERT(size_ >= *bytes);
   *bytes = size_;
   return space_;
 }
 
 
 } }  // namespace v8::internal