Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2389693002: service worker: Add NavigationPreload runtime flag and skeleton interface (Closed)

Created:
4 years, 2 months ago by falken
Modified:
4 years, 2 months ago
Reviewers:
haraken, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, tzik
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

service worker: Add NavigationPreload runtime flag and skeleton interface This just adds the runtime flag and a dummy implementation. Actual code and tests are to come in future patches. This patch is based on the WIP spec change here: https://github.com/w3c/ServiceWorker/pull/983/files BUG=649558 Committed: https://crrev.com/9a2b454a609338388dec903980267f3c7141a97f Cr-Commit-Position: refs/heads/master@{#424382}

Patch Set 1 #

Total comments: 2

Patch Set 2 : new API #

Patch Set 3 : forgot some files #

Patch Set 4 : forgot some gni #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules_idl_files.gni View 1 2 3 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.h View 1 2 1 chunk +37 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.cpp View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadManager.idl View 1 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadState.idl View 1 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp View 1 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 27 (18 generated)
falken
PTAL. I started writing https://codereview.chromium.org/2388023002 but decided to split up the patch even more.
4 years, 2 months ago (2016-10-03 07:57:32 UTC) #2
horo
https://codereview.chromium.org/2389693002/diff/1/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadOptions.idl File third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadOptions.idl (right): https://codereview.chromium.org/2389693002/diff/1/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadOptions.idl#newcode6 third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadOptions.idl:6: ByteString value; Add a link to the spec discussion ...
4 years, 2 months ago (2016-10-03 14:05:16 UTC) #7
falken
Updated to match new spec. PTAL.
4 years, 2 months ago (2016-10-07 07:47:47 UTC) #10
horo
lgtm
4 years, 2 months ago (2016-10-11 02:41:03 UTC) #18
falken
haraken please review: - third_party/WebKit/Source/modules/modules_idl_files.gni - third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
4 years, 2 months ago (2016-10-11 03:31:25 UTC) #20
haraken
On 2016/10/11 03:31:25, falken wrote: > haraken please review: > - third_party/WebKit/Source/modules/modules_idl_files.gni > - third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in ...
4 years, 2 months ago (2016-10-11 03:38:20 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389693002/60001
4 years, 2 months ago (2016-10-11 03:39:51 UTC) #23
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-10-11 07:04:00 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-10-11 07:06:15 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9a2b454a609338388dec903980267f3c7141a97f
Cr-Commit-Position: refs/heads/master@{#424382}

Powered by Google App Engine
This is Rietveld 408576698