Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2389663002: Add haraken@ to public/OWNERS (Closed)

Created:
4 years, 2 months ago by haraken
Modified:
4 years, 2 months ago
CC:
abarth-chromium, blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add haraken@ to public/OWNERS I've reviewed a lot of patches that need changes to public/ mostly in the context of Onion Soup. Also I hope this will be helpful to increase active reviewers in APAC time who can review trivial changes to public/. BUG= NOTRY=true Committed: https://crrev.com/e43da5a8fb226ea71f9b8ef11902495878034782 Cr-Commit-Position: refs/heads/master@{#422678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/public/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
haraken
PTAL
4 years, 2 months ago (2016-10-03 05:20:52 UTC) #2
esprehn
Lgtm. Keep the api small :)
4 years, 2 months ago (2016-10-03 07:09:34 UTC) #3
dcheng
LGTM 2
4 years, 2 months ago (2016-10-03 07:17:24 UTC) #4
foolip
lgtm 3
4 years, 2 months ago (2016-10-03 07:46:53 UTC) #5
Rick Byers
lgtm 4
4 years, 2 months ago (2016-10-03 15:07:03 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-10-03 15:25:53 UTC) #7
haraken
Thanks all! Let me land this.
4 years, 2 months ago (2016-10-04 02:40:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389663002/1
4 years, 2 months ago (2016-10-04 02:41:23 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 02:47:05 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 02:49:04 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e43da5a8fb226ea71f9b8ef11902495878034782
Cr-Commit-Position: refs/heads/master@{#422678}

Powered by Google App Engine
This is Rietveld 408576698