Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2389653002: Prune createVisibleSelectionDeprecated from SelectionAdjuster (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisibleSelectionDeprecated from SelectionAdjuster BUG=651373 Committed: https://crrev.com/1301c7b47926fa0d435c2f396a6aeba2a4d179c1 Cr-Commit-Position: refs/heads/master@{#422380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (10 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-03 06:10:08 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-03 06:28:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389653002/1
4 years, 2 months ago (2016-10-03 06:51:16 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 06:55:28 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1301c7b47926fa0d435c2f396a6aeba2a4d179c1 Cr-Commit-Position: refs/heads/master@{#422380}
4 years, 2 months ago (2016-10-03 06:57:16 UTC) #15
Xiaocheng
4 years, 2 months ago (2016-10-04 10:30:26 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2391973002/ by xiaochengh@chromium.org.

The reason for reverting is: Suspected of causing crbug.com/652301.

Powered by Google App Engine
This is Rietveld 408576698