Chromium Code Reviews

Issue 2389553002: [grokdump] Web iface: fix stack summary, add buffering. (Closed)

Created:
4 years, 2 months ago by Jarin
Modified:
4 years, 2 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[grokdump] Web iface: fix stack summary, add buffering. Committed: https://crrev.com/a87f0cfa7c4a11ea724ab7c62938c6d539434b4a Cr-Commit-Position: refs/heads/master@{#39945}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+26 lines, -10 lines)
M tools/grokdump.py View 5 chunks +26 lines, -10 lines 1 comment

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look, please? As you predicted, buffering the html helped a lot ...
4 years, 2 months ago (2016-10-01 18:36:35 UTC) #2
Camillo Bruni
LGTM with nit https://codereview.chromium.org/2389553002/diff/1/tools/grokdump.py File tools/grokdump.py (right): https://codereview.chromium.org/2389553002/diff/1/tools/grokdump.py#newcode2107 tools/grokdump.py:2107: self.wfile.write(out_buffer.getvalue()) nit: maybe pull the buffer ...
4 years, 2 months ago (2016-10-04 07:38:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389553002/1
4 years, 2 months ago (2016-10-04 08:11:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-04 08:37:05 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 08:37:23 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a87f0cfa7c4a11ea724ab7c62938c6d539434b4a
Cr-Commit-Position: refs/heads/master@{#39945}

Powered by Google App Engine