[grokdump] Web iface: fix stack summary, add buffering.

[grokdump] Web iface: fix stack summary, add buffering.

Committed: https://crrev.com/a87f0cfa7c4a11ea724ab7c62938c6d539434b4a
Cr-Commit-Position: refs/heads/master@{#39945}

[Jarin, 2016-10-01 18:36:35]

jarin@chromium.org changed reviewers:
+ cbruni@chromium.org

[Jarin, 2016-10-01 18:36:35]

Could you take a look, please?

As you predicted, buffering the html helped a lot to display long stack dumps
fast.

[Camillo Bruni, 2016-10-04 07:38:20]

LGTM with nit

https://codereview.chromium.org/2389553002/diff/1/tools/grokdump.py
File tools/grokdump.py (right):

https://codereview.chromium.org/2389553002/diff/1/tools/grokdump.py#newcode2107
tools/grokdump.py:2107: self.wfile.write(out_buffer.getvalue())
nit: maybe pull the buffer creation and flushing out to the enclosing function.

[Jarin, 2016-10-04 08:11:39]

The CQ bit was checked by jarin@chromium.org

[commit-bot: I haz the power, 2016-10-04 08:11:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 08:37:05]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-04 08:37:22]

Description was changed from

==========
[grokdump] Web iface: fix stack summary, add buffering.
==========

to

==========
[grokdump] Web iface: fix stack summary, add buffering.

Committed: https://crrev.com/a87f0cfa7c4a11ea724ab7c62938c6d539434b4a
Cr-Commit-Position: refs/heads/master@{#39945}
==========

[commit-bot: I haz the power, 2016-10-04 08:37:23]

Patchset 1 (id:??) landed as
https://crrev.com/a87f0cfa7c4a11ea724ab7c62938c6d539434b4a
Cr-Commit-Position: refs/heads/master@{#39945}