Issue 238953003: Point nacl tests to correct browser on 64-bit Windows

Issue 238953003: Point nacl tests to correct browser on 64-bit Windows (Closed)

Created:
6 years, 8 months ago by Paweł Hajdan Jr.

Modified:
6 years, 8 months ago

Reviewers:
Michael Achenbach

CC:
chromium-reviews, kjellander-cc_chromium.org, cmp-cc_chromium.org, ilevy-cc_chromium.org, stip+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/build

Visibility:
Public.

More Reviews

Description

Point nacl tests to correct browser on 64-bit Windows BUG=358130 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=263814

Patch Set 2 : fixes #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -11 lines)			Patch
M	scripts/slave/recipe_modules/chromium/api.py	View	1	2 chunks	+2 lines, -8 lines	1 comment	Download
M	scripts/slave/recipes/chromium_trybot.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_x64_dbg.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_chromium_x64_rel.json	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

This is similar to https://codereview.chromium.org/235423003/

6 years, 8 months ago (2014-04-15 11:01:38 UTC) #1

Michael Achenbach

https://codereview.chromium.org/238953003/diff/1/scripts/slave/recipes/chromium_trybot.py File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/238953003/diff/1/scripts/slave/recipes/chromium_trybot.py#newcode361 scripts/slave/recipes/chromium_trybot.py:361: mode = api.chromium.c.BUILD_CONFIG Please try using api.chromium.c.build_config_fs instead. It ...

6 years, 8 months ago (2014-04-15 11:09:40 UTC) #2

Paweł Hajdan Jr.

https://codereview.chromium.org/238953003/diff/1/scripts/slave/recipes/chromium_trybot.py File scripts/slave/recipes/chromium_trybot.py (right): https://codereview.chromium.org/238953003/diff/1/scripts/slave/recipes/chromium_trybot.py#newcode361 scripts/slave/recipes/chromium_trybot.py:361: mode = api.chromium.c.BUILD_CONFIG On 2014/04/15 11:09:40, Michael Achenbach wrote: ...

6 years, 8 months ago (2014-04-15 11:33:50 UTC) #3

Michael Achenbach

lgtm with a comment: https://codereview.chromium.org/238953003/diff/20001/scripts/slave/recipe_modules/chromium/api.py File scripts/slave/recipe_modules/chromium/api.py (right): https://codereview.chromium.org/238953003/diff/20001/scripts/slave/recipe_modules/chromium/api.py#newcode221 scripts/slave/recipe_modules/chromium/api.py:221: args=['--browser=%s' % self.c.build_config_fs.lower()], Assuming the ...

6 years, 8 months ago (2014-04-15 11:37:34 UTC) #4

Paweł Hajdan Jr.

The CQ bit was checked by phajdan.jr@chromium.org

6 years, 8 months ago (2014-04-15 12:04:54 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/238953003/20001

6 years, 8 months ago (2014-04-15 12:05:13 UTC) #6

Message was sent while issue was closed.

Change committed as 263814

Expand Messages | Collapse Messages