The ones that were replaced are now completely different. Were they just not being used ...
4 years, 2 months ago
(2016-10-03 13:46:56 UTC)
#3
The ones that were replaced are now completely different.
Were they just not being used before?
Also could you explain what the diff files are? I'm assuming
it's an image showing the diff between the Mac and Linux
outputs, is this correct? Is this related to some bug#?
Other than that lg
Lei Zhang
On 2016/10/03 13:46:56, npm wrote: > The ones that were replaced are now completely different. ...
4 years, 2 months ago
(2016-10-03 16:25:35 UTC)
#4
On 2016/10/03 13:46:56, npm wrote:
> The ones that were replaced are now completely different.
> Were they just not being used before?
All the files are additions. If you are referring to the "A+" files, that's just
git being silly and thinking the newly added file is a copy of an existing file.
I can reupload with --similarity={0,100} (can't remember which) so they are all
"A" instead.
> Also could you explain what the diff files are? I'm assuming
> it's an image showing the diff between the Mac and Linux
> outputs, is this correct? Is this related to some bug#?
For a given FRC PDF, the diff shows the visual diff between the existing
expectation and the new Mac expectation output.
There's no bug. It's just to reduce the amount of suppressions. As is, the Mac
rendering can go completely bunkers, but the same suppression applied and
corpus_tests won't produce an error. With these new expectations, we at least
have a baseline for what Mac rendering should look like, even if it is slightly
off from Win/Linux.
npm
lgtm
4 years, 2 months ago
(2016-10-03 17:04:06 UTC)
#5
lgtm
Lei Zhang
Description was changed from ========== Add Mac expectations for FRC PDFs. ========== to ========== Add ...
4 years, 2 months ago
(2016-10-03 21:20:00 UTC)
#6
Issue 2389513002: Add Mac expectations for FRC PDFs.
(Closed)
Created 4 years, 2 months ago by Lei Zhang
Modified 4 years, 2 months ago
Reviewers: npm
Base URL:
Comments: 0