Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2389503002: reflow comments in wtf/typed_arrays (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
dcheng
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

reflow comments in wtf/typed_arrays BUG=563793 Committed: https://crrev.com/7f9ede63f194fa5e4cf1c62e2b72dbc9f1ee0471 Cr-Commit-Position: refs/heads/master@{#422299}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferContents.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Nico
4 years, 2 months ago (2016-10-01 02:32:27 UTC) #4
dcheng
LGTM with a nit https://codereview.chromium.org/2389503002/diff/1/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h File third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h (right): https://codereview.chromium.org/2389503002/diff/1/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h#newcode53 third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h:53: // Internals::serializeObject Nit, it looks ...
4 years, 2 months ago (2016-10-01 02:41:51 UTC) #5
Nico
https://codereview.chromium.org/2389503002/diff/1/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h File third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h (right): https://codereview.chromium.org/2389503002/diff/1/third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h#newcode53 third_party/WebKit/Source/wtf/typed_arrays/ArrayBuffer.h:53: // Internals::serializeObject On 2016/10/01 02:41:51, dcheng wrote: > Nit, ...
4 years, 2 months ago (2016-10-01 02:49:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389503002/20001
4 years, 2 months ago (2016-10-01 02:49:46 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-01 04:59:03 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-01 05:00:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7f9ede63f194fa5e4cf1c62e2b72dbc9f1ee0471
Cr-Commit-Position: refs/heads/master@{#422299}

Powered by Google App Engine
This is Rietveld 408576698