Make the Unix editing behavior the default

Make the Unix editing behavior the default.

The change removes unreachable code and does not actually change any behavior.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157777

[lgombos, 2013-09-08 22:29:40]

As the comment in the code suggests - EditingUnixBehavior comprises all
unix-based systems, but Darwin/MacOS/Android (and then abusing the terminology);

This might be a good opportunity to rename EditingUnixBehavior to
EditingDefaultBehavior.

Thoughts ?

[abarth-chromium, 2013-09-08 22:42:48]

https://codereview.chromium.org/23895006/diff/1/Source/core/page/Settings.cpp
File Source/core/page/Settings.cpp (right):

https://codereview.chromium.org/23895006/diff/1/Source/core/page/Settings.cpp...
Source/core/page/Settings.cpp:98: EditingUnixBehavior
Why not be explicit and then have a #error in the default case?

[lgombos, 2013-09-08 23:45:09]

On 2013/09/08 22:42:48, abarth wrote:
> https://codereview.chromium.org/23895006/diff/1/Source/core/page/Settings.cpp
> File Source/core/page/Settings.cpp (right):
> 
>
https://codereview.chromium.org/23895006/diff/1/Source/core/page/Settings.cpp...
> Source/core/page/Settings.cpp:98: EditingUnixBehavior
> Why not be explicit and then have a #error in the default case?

I think it would be useful to document some of the assumptions/invariants we
have in the code around OS() defines. As an example I would love to see the
following in config.h

#if !OS(WINDOWS) && !OS(UNIX)
#error Either OS(WINDOWS) or OS(UNIX) needs to be set 
#endif

I was trying to avoid putting this assumption all over the code base as there
are many places where this is already assumed without having an #error in place.

[lgombos, 2013-09-09 00:06:54]

Also - in general - from all of the OS() macros we have the one changing most is
OS(UNIX) with the removal/addition of support for UNIX-like operating systems. I
think in most cases it is good to have the OS(UNIX) case to be the default/catch
all case, and try to minimize the explicit use of OS(UNIX) when we have a
choice.

Some related work here - https://codereview.chromium.org/23654015/

[lgombos, 2013-09-13 15:07:58]

I added the "explicit #error" globally to config.h.

What do you think Adam ?

[abarth-chromium, 2013-09-13 17:44:25]

lgtm

[commit-bot: I haz the power, 2013-09-13 17:44:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/l.gombos@samsung.com/23895006/9001

[commit-bot: I haz the power, 2013-09-13 19:48:43]

Change committed as 157777