Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: remoting/client/jni/jni_client.cc

Issue 2389463002: [Remoting Android] Separate the display core from JniGlDisplayHandler (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/jni/jni_client.cc
diff --git a/remoting/client/jni/jni_client.cc b/remoting/client/jni/jni_client.cc
index 8265ac268daba885b67467df24385bbc9ec383cc..9581d8ccb6485233490d1c1bf0dc6f0ff7130e75 100644
--- a/remoting/client/jni/jni_client.cc
+++ b/remoting/client/jni/jni_client.cc
@@ -48,8 +48,10 @@ void JniClient::ConnectToHost(const std::string& username,
const std::string& capabilities,
const std::string& flags) {
DCHECK(runtime_->ui_task_runner()->BelongsToCurrentThread());
+ DCHECK(!display_handler_);
DCHECK(!session_);
DCHECK(!secret_fetcher_);
+ display_handler_.reset(new JniGlDisplayHandler(runtime_, java_client_));
secret_fetcher_.reset(new JniPairingSecretFetcher(runtime_, GetWeakPtr(),
host_id));
session_.reset(new ChromotingJniInstance(
@@ -72,11 +74,7 @@ void JniClient::DisconnectFromHost() {
runtime_->network_task_runner()->DeleteSoon(FROM_HERE,
secret_fetcher_.release());
}
- if (display_handler_) {
- display_handler_->Invalidate();
- runtime_->display_task_runner()->DeleteSoon(FROM_HERE,
- display_handler_.release());
- }
+ display_handler_.reset();
}
void JniClient::OnConnectionState(protocol::ConnectionToHost::State state,
@@ -161,8 +159,6 @@ void JniClient::Connect(
const base::android::JavaParamRef<jstring>& pairSecret,
const base::android::JavaParamRef<jstring>& capabilities,
const base::android::JavaParamRef<jstring>& flags) {
- display_handler_.reset(new JniGlDisplayHandler(runtime_));
- display_handler_->Initialize(java_client_);
ConnectToHost(ConvertJavaStringToUTF8(env, username),
ConvertJavaStringToUTF8(env, authToken),
ConvertJavaStringToUTF8(env, hostJid),
« no previous file with comments | « no previous file | remoting/client/jni/jni_gl_display_handler.h » ('j') | remoting/client/jni/jni_gl_display_handler.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698