Issue 2389443002: AOT+ARM: Use predication for CheckedSmiOp comparisions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2389443002: AOT+ARM: Use predication for CheckedSmiOp comparisions. (Closed)

Created:
4 years, 2 months ago by rmacnak

Modified:
4 years, 2 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

AOT+ARM: Use predication for CheckedSmiOp comparisions. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/0cb2eb9f5e57ccae3738cd61fe8379bbf4fd490a

Patch Set 1 #

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -9 lines)			Patch
	M	runtime/vm/intermediate_language_arm.cc	View		1 chunk	+2 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

Fluttery gallery Before: VMIsolate(CodeSize): 113192 Isolate(CodeSize): 2061396 ReadOnlyData(CodeSize): 1723328 Instructions(CodeSize): 5599936 Total(CodeSize): 9497852 After: VMIsolate(CodeSize): ...

4 years, 2 months ago (2016-09-30 22:04:57 UTC) #2

rmacnak

4 years, 2 months ago (2016-10-06 18:21:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0cb2eb9f5e57ccae3738cd61fe8379bbf4fd490a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages