chromeos: Don't explicitly set system tray visibility during initialization

chromeos: Don't explicitly set system tray visibility during initialization

This allows SystemTrayDelegate::GetTrayVisibilityOnStartup() to be removed,
so we don't have to port it to mustash.

The visibility is controlled explicitly via chrome's login WizardController
and implicitly by login status changes.

BUG=647412
TEST=ash_unittests, chrome browser_tests

Committed: https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da
Cr-Commit-Position: refs/heads/master@{#423344}

[James Cook, 2016-10-05 18:06:54]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 18:07:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-05 18:26:22]

Description was changed from

==========
chromeos: Set system tray view to invisible during initialization

This allows SystemTrayDelegate::GetTrayVisibilityOnStartup() to be removed,
so we don't have to port it to mustash.

The visibility is controlled explicitly via chrome's login WizardController
and implicitly by login status changes.

It starts as false because OOBE will show the system tray on the primary
after the web UI animates in the button bar at the bottom.

BUG=647412
TEST=ash_unittests, chrome browser_tests
==========

to

==========
chromeos: Don't explicitly set system tray visibility during initialization

This allows SystemTrayDelegate::GetTrayVisibilityOnStartup() to be removed,
so we don't have to port it to mustash.

The visibility is controlled explicitly via chrome's login WizardController
and implicitly by login status changes.

BUG=647412
TEST=ash_unittests, chrome browser_tests
==========

[James Cook, 2016-10-05 18:37:36]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 18:38:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-05 18:48:48]

jamescook@chromium.org changed reviewers:
+ michaelpg@chromium.org

[James Cook, 2016-10-05 18:48:49]

michaelpg, please take a look. (This vaguely relates to the work you did for
crbug.com/363870 "Show status area at OOBE")

xiyuan, just FYI

[commit-bot: I haz the power, 2016-10-05 19:02:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 19:02:46]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[James Cook, 2016-10-05 19:22:30]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-05 19:23:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 20:07:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 20:07:30]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2016-10-05 23:32:53]

lgtm, but i'm not confident what the implications of this are

please update the subject and description to match each other :-)

[James Cook, 2016-10-05 23:33:52]

Description was changed from

==========
chromeos: Don't explicitly set system tray visibility during initialization

This allows SystemTrayDelegate::GetTrayVisibilityOnStartup() to be removed,
so we don't have to port it to mustash.

The visibility is controlled explicitly via chrome's login WizardController
and implicitly by login status changes.

BUG=647412
TEST=ash_unittests, chrome browser_tests
==========

to

==========
chromeos: Don't explicitly set system tray visibility during initialization

This allows SystemTrayDelegate::GetTrayVisibilityOnStartup() to be removed,
so we don't have to port it to mustash.

The visibility is controlled explicitly via chrome's login WizardController
and implicitly by login status changes.

BUG=647412
TEST=ash_unittests, chrome browser_tests
==========

[James Cook, 2016-10-05 23:41:36]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-10-05 23:41:37]

msw, can I get owners for c/b/ui/ash?

michaelpg, thanks for the review.  (I think it'll be OK. I spent several hours
going through all the OOBE / login / secondary monitor connect / disconnect
flows, both on and off device, and I didn't find any regressions. This will need
to change when WizardController runs in a different process than ash, but the
old code would have had to change too.)

[msw, 2016-10-05 23:48:55]

chrome/browser/ui/ash/ lgtm

[James Cook, 2016-10-05 23:49:13]

The CQ bit was checked by jamescook@chromium.org

[commit-bot: I haz the power, 2016-10-05 23:50:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 23:58:44]

Description was changed from

==========
chromeos: Don't explicitly set system tray visibility during initialization

This allows SystemTrayDelegate::GetTrayVisibilityOnStartup() to be removed,
so we don't have to port it to mustash.

The visibility is controlled explicitly via chrome's login WizardController
and implicitly by login status changes.

BUG=647412
TEST=ash_unittests, chrome browser_tests
==========

to

==========
chromeos: Don't explicitly set system tray visibility during initialization

This allows SystemTrayDelegate::GetTrayVisibilityOnStartup() to be removed,
so we don't have to port it to mustash.

The visibility is controlled explicitly via chrome's login WizardController
and implicitly by login status changes.

BUG=647412
TEST=ash_unittests, chrome browser_tests
==========

[commit-bot: I haz the power, 2016-10-05 23:58:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-06 00:00:00]

Description was changed from

==========
chromeos: Don't explicitly set system tray visibility during initialization

This allows SystemTrayDelegate::GetTrayVisibilityOnStartup() to be removed,
so we don't have to port it to mustash.

The visibility is controlled explicitly via chrome's login WizardController
and implicitly by login status changes.

BUG=647412
TEST=ash_unittests, chrome browser_tests
==========

to

==========
chromeos: Don't explicitly set system tray visibility during initialization

This allows SystemTrayDelegate::GetTrayVisibilityOnStartup() to be removed,
so we don't have to port it to mustash.

The visibility is controlled explicitly via chrome's login WizardController
and implicitly by login status changes.

BUG=647412
TEST=ash_unittests, chrome browser_tests

Committed: https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da
Cr-Commit-Position: refs/heads/master@{#423344}
==========

[commit-bot: I haz the power, 2016-10-06 00:00:02]

Patchset 3 (id:??) landed as
https://crrev.com/c17dff06e0421bf73c533d4b3a626ed39585f4da
Cr-Commit-Position: refs/heads/master@{#423344}

[michaelpg, 2016-10-06 07:49:26]

On 2016/10/05 23:41:37, James Cook (OOO until Oct 10) wrote:
> msw, can I get owners for c/b/ui/ash?
> 
> michaelpg, thanks for the review.  (I think it'll be OK. I spent several hours
> going through all the OOBE / login / secondary monitor connect / disconnect
> flows, both on and off device, and I didn't find any regressions. This will
need
> to change when WizardController runs in a different process than ash, but the
> old code would have had to change too.)

w00t. The only consideration I'll mention is that the Set Date/Time dialog must
be accessible (can be opened from the system tray menu if we haven't synced
internet time since boot)