Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2389403002: Remove null checking in JavaObjectWeakGlobalRef ctr (Closed)

Created:
4 years, 2 months ago by Jinsuk Kim
Modified:
4 years, 2 months ago
Reviewers:
Torne
CC:
chromium-reviews, boliu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove null checking in JavaObjectWeakGlobalRef ctr It is legal to create a weak reference to null. Removes the defensive null checking being done in the constructors. BUG=649407 Committed: https://crrev.com/48678a7b6e9087357262f8acee9df186b337d706 Cr-Commit-Position: refs/heads/master@{#423143}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M base/android/jni_weak_ref.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jinsuk Kim
4 years, 2 months ago (2016-10-05 01:05:55 UTC) #2
Torne
lgtm
4 years, 2 months ago (2016-10-05 10:41:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389403002/1
4 years, 2 months ago (2016-10-05 12:59:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 13:41:37 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 13:43:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48678a7b6e9087357262f8acee9df186b337d706
Cr-Commit-Position: refs/heads/master@{#423143}

Powered by Google App Engine
This is Rietveld 408576698