Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2389393002: MD History: Do not collapse synced device card when tapping menu button (Closed)

Created:
4 years, 2 months ago by tsergeant
Modified:
4 years, 2 months ago
Reviewers:
calamity
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Use click instead of tap events for synced device collapsing This fixes an issue where using touch to open the synced device actions menu would also collapse the device card, since one event used on-tap and the other used on-click. BUG=652634, 650551 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/95f84bba89a39f5d70372bb08dfb159208f6b6c0 Cr-Commit-Position: refs/heads/master@{#423091}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/browser/resources/md_history/lazy_load.vulcanized.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_history/synced_device_card.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/md_history/history_synced_tabs_test.js View 1 chunk +12 lines, -0 lines 2 comments Download

Messages

Total messages: 14 (9 generated)
tsergeant
https://codereview.chromium.org/2389393002/diff/1/chrome/test/data/webui/md_history/history_synced_tabs_test.js File chrome/test/data/webui/md_history/history_synced_tabs_test.js (right): https://codereview.chromium.org/2389393002/diff/1/chrome/test/data/webui/md_history/history_synced_tabs_test.js#newcode254 chrome/test/data/webui/md_history/history_synced_tabs_test.js:254: test('show actions menu', function() { Sadly, I have not ...
4 years, 2 months ago (2016-10-05 02:06:24 UTC) #8
calamity
lgtm https://codereview.chromium.org/2389393002/diff/1/chrome/test/data/webui/md_history/history_synced_tabs_test.js File chrome/test/data/webui/md_history/history_synced_tabs_test.js (right): https://codereview.chromium.org/2389393002/diff/1/chrome/test/data/webui/md_history/history_synced_tabs_test.js#newcode254 chrome/test/data/webui/md_history/history_synced_tabs_test.js:254: test('show actions menu', function() { On 2016/10/05 02:06:24, ...
4 years, 2 months ago (2016-10-05 04:45:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389393002/1
4 years, 2 months ago (2016-10-05 06:25:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 06:31:07 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 06:32:54 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95f84bba89a39f5d70372bb08dfb159208f6b6c0
Cr-Commit-Position: refs/heads/master@{#423091}

Powered by Google App Engine
This is Rietveld 408576698