Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2389353004: Fix pylint warnings: build/gn_helpers.py (Closed)

Created:
4 years, 2 months ago by Yoshisato Yanagisawa
Modified:
4 years, 2 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix pylint warnings: build/gn_helpers.py ************* Module gn_helpers W: 68,17: Redefining built-in 'input' (redefined-builtin) W:108,15: Redefining built-in 'input' (redefined-builtin) W:242, 4: Redefining built-in 'id' (redefined-builtin) Committed: https://crrev.com/18ef930c632de1aa0d4850671f0f9522e6674961 Cr-Commit-Position: refs/heads/master@{#423785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M build/gn_helpers.py View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Yoshisato Yanagisawa
4 years, 2 months ago (2016-10-06 08:00:57 UTC) #2
Dirk Pranke
lgtm.
4 years, 2 months ago (2016-10-06 17:00:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389353004/1
4 years, 2 months ago (2016-10-07 02:22:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 02:35:55 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 02:38:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18ef930c632de1aa0d4850671f0f9522e6674961
Cr-Commit-Position: refs/heads/master@{#423785}

Powered by Google App Engine
This is Rietveld 408576698