Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2389353002: chromeos: Fix case of "Get info" string in Files app. (Closed)

Created:
4 years, 2 months ago by Daniel Erat
Modified:
4 years, 2 months ago
Reviewers:
hirono
CC:
chromium-reviews, harukam1, fukino
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

chromeos: Fix case of "Get info" string in Files app. Chrome context menu items use "Sentence case" on Chrome OS. Fix the Files app's "Get Info" string. Also add a few missing descriptions for other strings. BUG=none Committed: https://crrev.com/930eb30a4b7cbf49ac5231a2953f2a03bb11c923 Cr-Commit-Position: refs/heads/master@{#423027}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/app/chromeos_strings.grdp View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Daniel Erat
4 years, 2 months ago (2016-10-05 00:23:10 UTC) #2
hirono
lgtm, thank you for the fix!
4 years, 2 months ago (2016-10-05 00:25:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389353002/1
4 years, 2 months ago (2016-10-05 00:35:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-05 00:48:59 UTC) #8
commit-bot: I haz the power
4 years, 2 months ago (2016-10-05 00:52:58 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/930eb30a4b7cbf49ac5231a2953f2a03bb11c923
Cr-Commit-Position: refs/heads/master@{#423027}

Powered by Google App Engine
This is Rietveld 408576698