[Mac] Updating AutocompleteTextFieldCell to 10.8

[Mac] Updating AutocompleteTextFieldCell to 10.8

Opening and writing to the resource forks are deprecated on macOS.
As a result, its usage should be removed.

BUG=650798
Committed: https://crrev.com/e4ec3055dbc64a64eec023566493970ba010c57f
Cr-Commit-Position: refs/heads/master@{#423889}

[spqchan, 2016-10-04 23:32:52]

Patchset #2 (id:20001) has been deleted

[spqchan, 2016-10-04 23:39:08]

Description was changed from

==========
[Mac]

BUG=
==========

to

==========
[Mac] Updating AutocompleteTextFieldCell to 10.8

Opening and writing to the resource forks are deprecated on macOS.
As a result, its usage should be removed and we should just write to the
.webloc plist file.

BUG=650798
==========

[spqchan, 2016-10-04 23:40:51]

spqchan@chromium.org changed reviewers:
+ rsesek@chromium.org

[spqchan, 2016-10-04 23:40:51]

PTAL

[Robert Sesek, 2016-10-05 17:32:03]

https://codereview.chromium.org/2389343002/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
(right):

https://codereview.chromium.org/2389343002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm:620: //
Write the URL to the .webloc plist url file.
Isn't this being done on line 605 already?

[spqchan, 2016-10-06 23:41:07]

Description was changed from

==========
[Mac] Updating AutocompleteTextFieldCell to 10.8

Opening and writing to the resource forks are deprecated on macOS.
As a result, its usage should be removed and we should just write to the
.webloc plist file.

BUG=650798
==========

to

==========
[Mac] Updating AutocompleteTextFieldCell to 10.8

Opening and writing to the resource forks are deprecated on macOS.
As a result, its usage should be removed.

BUG=650798
==========

[spqchan, 2016-10-06 23:41:20]

PTAL

https://codereview.chromium.org/2389343002/diff/40001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
(right):

https://codereview.chromium.org/2389343002/diff/40001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm:620: //
Write the URL to the .webloc plist url file.
On 2016/10/05 17:32:03, Robert Sesek wrote:
> Isn't this being done on line 605 already?

Wow, I can't believe I missed that. Looks like the only thing I need is to
remove the resource forks.
Thanks for catching it!

[Robert Sesek, 2016-10-07 14:37:40]

lgtm

[spqchan, 2016-10-07 16:33:14]

On 2016/10/07 14:37:40, Robert Sesek wrote:
> lgtm

thanks!

[spqchan, 2016-10-07 16:33:20]

The CQ bit was checked by spqchan@chromium.org

[commit-bot: I haz the power, 2016-10-07 16:33:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 16:59:43]

Description was changed from

==========
[Mac] Updating AutocompleteTextFieldCell to 10.8

Opening and writing to the resource forks are deprecated on macOS.
As a result, its usage should be removed.

BUG=650798
==========

to

==========
[Mac] Updating AutocompleteTextFieldCell to 10.8

Opening and writing to the resource forks are deprecated on macOS.
As a result, its usage should be removed.

BUG=650798
==========

[commit-bot: I haz the power, 2016-10-07 16:59:44]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-10-07 17:02:20]

Description was changed from

==========
[Mac] Updating AutocompleteTextFieldCell to 10.8

Opening and writing to the resource forks are deprecated on macOS.
As a result, its usage should be removed.

BUG=650798
==========

to

==========
[Mac] Updating AutocompleteTextFieldCell to 10.8

Opening and writing to the resource forks are deprecated on macOS.
As a result, its usage should be removed.

BUG=650798

Committed: https://crrev.com/e4ec3055dbc64a64eec023566493970ba010c57f
Cr-Commit-Position: refs/heads/master@{#423889}
==========

[commit-bot: I haz the power, 2016-10-07 17:02:20]

Patchset 3 (id:??) landed as
https://crrev.com/e4ec3055dbc64a64eec023566493970ba010c57f
Cr-Commit-Position: refs/heads/master@{#423889}