DevTools: update styles for debugger's CallStackSidebarPane

DevTools: update styles for debugger's CallStackSidebarPane

- async links now format the same as non-async links
- updated gray color
- async dividers aligned to the left
- line separators only appear for async dividers

BUG=652461
Committed: https://crrev.com/2ae84df4a969c7b0f17f66a25e29fb59cc484a4d
Cr-Commit-Position: refs/heads/master@{#424929}

[luoe, 2016-10-04 23:21:15]

Description was changed from

==========
DevTools: update styles for debugger

BUG=652461
==========

to

==========
DevTools: update styles for debugger's CallStackSidebarPane

- async links now format the same as non-async links
- updated gray color
- async dividers aligned to the left
- line separators only appear for async dividers

BUG=652461
==========

[luoe, 2016-10-05 00:00:49]

luoe@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org, lushnikov@chromium.org

[luoe, 2016-10-05 00:00:50]

lushnikov: general frontend review
kozyatinskiy: async callframes no longer using linkifier.linkifyRawLocation(). 
Instead, it now calls createCallFrameLiveLocation() directly.
- The test makes sure that formatting a file that is a source of an async
callframe modifies the link text

PTAL

[luoe, 2016-10-07 01:28:45]

Updated styles of the callstack.  Please see screenshot for details
https://bugs.chromium.org/p/chromium/issues/detail?id=652461#c6

[kozy, 2016-10-07 22:26:54]

lgtm % Andrey's comments

[lushnikov, 2016-10-07 22:28:30]

https://codereview.chromium.org/2389333002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
(left):

https://codereview.chromium.org/2389333002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js:478:
this._liveLocationPool = new WebInspector.LiveLocationPool();
this should go to the outside

[luoe, 2016-10-07 22:38:36]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 22:39:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[luoe, 2016-10-07 23:18:59]

https://codereview.chromium.org/2389333002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js
(left):

https://codereview.chromium.org/2389333002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sources/CallStackSidebarPane.js:478:
this._liveLocationPool = new WebInspector.LiveLocationPool();
On 2016/10/07 22:28:29, lushnikov wrote:
> this should go to the outside 

Removed, after checking that it wasn't used.

[commit-bot: I haz the power, 2016-10-07 23:52:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 23:52:34]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-10-07 23:53:29]

The CQ bit was checked by luoe@chromium.org

[luoe, 2016-10-07 23:53:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
kozyatinskiy@chromium.org
Link to the patchset: https://codereview.chromium.org/2389333002/#ps80001
(title: "reset result after reorder, address comments")

[commit-bot: I haz the power, 2016-10-07 23:53:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 23:59:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 23:59:40]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[lushnikov, 2016-10-12 21:41:56]

lgtm

https://codereview.chromium.org/2389333002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/viewContainers.css (right):

https://codereview.chromium.org/2389333002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/viewContainers.css:37:
background-color: #f3f3f3;
For the record: this is to align our greys; this changed is blessed by @chowse

[luoe, 2016-10-12 21:46:41]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-12 21:47:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 00:54:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-13 00:54:54]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-10-13 01:23:07]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-10-13 01:23:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-13 01:29:50]

Description was changed from

==========
DevTools: update styles for debugger's CallStackSidebarPane

- async links now format the same as non-async links
- updated gray color
- async dividers aligned to the left
- line separators only appear for async dividers

BUG=652461
==========

to

==========
DevTools: update styles for debugger's CallStackSidebarPane

- async links now format the same as non-async links
- updated gray color
- async dividers aligned to the left
- line separators only appear for async dividers

BUG=652461
==========

[commit-bot: I haz the power, 2016-10-13 01:29:51]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-13 01:31:37]

Description was changed from

==========
DevTools: update styles for debugger's CallStackSidebarPane

- async links now format the same as non-async links
- updated gray color
- async dividers aligned to the left
- line separators only appear for async dividers

BUG=652461
==========

to

==========
DevTools: update styles for debugger's CallStackSidebarPane

- async links now format the same as non-async links
- updated gray color
- async dividers aligned to the left
- line separators only appear for async dividers

BUG=652461

Committed: https://crrev.com/2ae84df4a969c7b0f17f66a25e29fb59cc484a4d
Cr-Commit-Position: refs/heads/master@{#424929}
==========

[commit-bot: I haz the power, 2016-10-13 01:31:38]

Patchset 5 (id:??) landed as
https://crrev.com/2ae84df4a969c7b0f17f66a25e29fb59cc484a4d
Cr-Commit-Position: refs/heads/master@{#424929}