gpu/command_buffer/service/gles2_cmd_decoder.cc - Issue 238933003: Re-land: gpu: Add CHROMIUM_sync_query extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 238933003: Re-land: gpu: Add CHROMIUM_sync_query extension. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address review feedback Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc

index 80ca20992977ab86eee0557860ea32b402cba336..37ab139eb82396eaa4159edef4ff72c3f2126fb1 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc

@@ -9512,6 +9512,7 @@ error::Error GLES2DecoderImpl::HandleBeginQueryEXT(

case GL_ASYNC_PIXEL_UNPACK_COMPLETED_CHROMIUM:

case GL_ASYNC_PIXEL_PACK_COMPLETED_CHROMIUM:

case GL_GET_ERROR_QUERY_CHROMIUM:

+ case GL_COMMANDS_COMPLETED_CHROMIUM:

piman 2014/04/16 00:32:03 We need to refuse this if the extension is not sup

reveman 2014/04/16 01:28:47 Done.

break;

default:

if (!features().occlusion_query_boolean) {