Issue 238933002: First round of runtime.cc handlification.

Issue 238933002: First round of runtime.cc handlification. (Closed)

Created:
6 years, 8 months ago by Dmitry Lomov (no reviews)

Modified:
6 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

First round of runtime.cc handlification. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20758

Patch Set 2 : Landing #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -57 lines)			Patch
M	src/objects.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/objects.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1	12 chunks	+61 lines, -57 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Yang

LGTM with nit. https://codereview.chromium.org/238933002/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/238933002/diff/1/src/runtime.cc#newcode1786 src/runtime.cc:1786: CONVERT_ARG_HANDLE_CHECKED(Object, O, 0); We usuall just ...

6 years, 8 months ago (2014-04-15 10:21:06 UTC) #2

Dmitry Lomov (no reviews)

Committed patchset #2 manually as r20758 (presubmit successful).

6 years, 8 months ago (2014-04-15 10:37:21 UTC) #3

Dmitry Lomov (no reviews)

https://codereview.chromium.org/238933002/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/238933002/diff/1/src/runtime.cc#newcode620 src/runtime.cc:620: RETURN_IF_EMPTY_HANDLE(isolate, symbol); Removed macro as discussed offline. https://codereview.chromium.org/238933002/diff/1/src/runtime.cc#newcode1786 src/runtime.cc:1786: ...

6 years, 8 months ago (2014-04-15 12:47:31 UTC) #4

Yang

6 years, 8 months ago (2014-04-15 12:52:32 UTC) #5

Message was sent while issue was closed.

On 2014/04/15 12:47:31, Dmitry Lomov (chromium) wrote:
> https://codereview.chromium.org/238933002/diff/1/src/runtime.cc
> File src/runtime.cc (right):
> 
> https://codereview.chromium.org/238933002/diff/1/src/runtime.cc#newcode620
> src/runtime.cc:620: RETURN_IF_EMPTY_HANDLE(isolate, symbol);
> Removed macro as discussed offline.
> 
> https://codereview.chromium.org/238933002/diff/1/src/runtime.cc#newcode1786
> src/runtime.cc:1786: CONVERT_ARG_HANDLE_CHECKED(Object, O, 0);
> On 2014/04/15 10:21:06, Yang wrote:
> > We usuall just use
> > Handle<Object> O = args.at<Object>(0);
> > 
> > since the arguments are always objects.
> 
> Done.

lgtm.

Expand Messages | Collapse Messages