Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2389323004: Merge //ios/chrome/browser/signin:{authentication_service,signin}. (Closed)

Created:
4 years, 2 months ago by sdefresne
Modified:
4 years, 2 months ago
Reviewers:
bzanotti
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge //ios/chrome/browser/signin:{authentication_service,signin}. The downstream code now depends on upstream implementation of AuthenticationService so merge the targets (but leave temporary targets until downstream code dependencies have been removed). BUG=653086 Committed: https://crrev.com/2bd748a74911f9e871bc53b5c10e7dc62b90717e Cr-Commit-Position: refs/heads/master@{#423870}

Patch Set 1 #

Patch Set 2 : Rebase and fix AuthenticationServiceTest tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -44 lines) Patch
M ios/chrome/browser/browser_state/browser_state_keyed_service_factories.mm View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/signin/BUILD.gn View 1 4 chunks +17 lines, -43 lines 0 comments Download
M ios/chrome/browser/signin/authentication_service_unittest.mm View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
sdefresne
Please take a look. I will wait until the corresponding downstream CL lands before sending ...
4 years, 2 months ago (2016-10-05 17:50:47 UTC) #4
bzanotti
LGTM
4 years, 2 months ago (2016-10-05 17:53:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389323004/20001
4 years, 2 months ago (2016-10-07 13:48:40 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-07 16:01:25 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 16:03:06 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2bd748a74911f9e871bc53b5c10e7dc62b90717e
Cr-Commit-Position: refs/heads/master@{#423870}

Powered by Google App Engine
This is Rietveld 408576698