Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Issue 2389303002: Add bindProxy implementation without callback. (Closed)

Created:
4 years, 2 months ago by mbrunson
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add bindProxy implementation without callback. The original implementation of bindProxy in Mojo connection requires a callback in order to receive the proxy for the remote interface. This pattern is counterintuitive and unnecessary. A new function that doesn't require a callback has been added here. Committed: https://crrev.com/3648b35f8ed44f505c4c62c7a63be90c66760006 Cr-Commit-Position: refs/heads/master@{#422992}

Patch Set 1 #

Patch Set 2 : Remove typo #

Total comments: 4

Patch Set 3 : Renaming #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
M mojo/public/js/connection.js View 1 2 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
mbrunson
This is that function that was added when we were trying to implement interface requests ...
4 years, 2 months ago (2016-10-04 21:35:59 UTC) #2
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/2389303002/diff/20001/mojo/public/js/connection.js File mojo/public/js/connection.js (right): https://codereview.chromium.org/2389303002/diff/20001/mojo/public/js/connection.js#newcode104 mojo/public/js/connection.js:104: function bindProxy2(remoteInterface) { Let's call this getProxy. We'll ...
4 years, 2 months ago (2016-10-04 22:36:51 UTC) #3
mbrunson
https://codereview.chromium.org/2389303002/diff/20001/mojo/public/js/connection.js File mojo/public/js/connection.js (right): https://codereview.chromium.org/2389303002/diff/20001/mojo/public/js/connection.js#newcode104 mojo/public/js/connection.js:104: function bindProxy2(remoteInterface) { On 2016/10/04 22:36:51, Ken Rockot wrote: ...
4 years, 2 months ago (2016-10-04 22:55:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389303002/40001
4 years, 2 months ago (2016-10-04 23:13:37 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-04 23:20:10 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 23:23:15 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3648b35f8ed44f505c4c62c7a63be90c66760006
Cr-Commit-Position: refs/heads/master@{#422992}

Powered by Google App Engine
This is Rietveld 408576698