Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2389263008: Delete fillViewport attribute from RecyclerView. (Closed)

Created:
4 years, 2 months ago by Michael van Ouwerkerk
Modified:
4 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delete fillViewport attribute from RecyclerView. It's an attribute for ScrollView, and a no-op on RecyclerView. Committed: https://crrev.com/fbf1f4cf1d1d55f6f1eec3d72deaa8bf329d76c7 Cr-Commit-Position: refs/heads/master@{#423850}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/android/java/res/layout/new_tab_page_recycler_view.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
4 years, 2 months ago (2016-10-07 13:43:14 UTC) #4
Bernhard Bauer
LGTM, thanks!
4 years, 2 months ago (2016-10-07 13:47:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389263008/1
4 years, 2 months ago (2016-10-07 14:09:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 14:15:43 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 14:18:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fbf1f4cf1d1d55f6f1eec3d72deaa8bf329d76c7
Cr-Commit-Position: refs/heads/master@{#423850}

Powered by Google App Engine
This is Rietveld 408576698