Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 2389263007: Use sysroot for dpkg-shlibdeps when building debian package (Closed)

Created:
4 years, 2 months ago by Sam Clegg
Modified:
4 years, 2 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, Michael Moss, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use sysroot for dpkg-shlibdeps when building debian package Previously we were using the host environment to calculate shlibdeps. BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/installer/linux/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/installer/linux/debian/build.sh View 3 chunks +8 lines, -2 lines 2 comments Download

Messages

Total messages: 10 (3 generated)
Sam Clegg
This change depends on having a var/lib/dpkg/ correctly configured in the sysroot images (https://codereview.chromium.org/2391183002/)
4 years, 2 months ago (2016-10-06 18:42:01 UTC) #2
Lei Zhang
Looks similar to my version of this CL, so I'm all for it. https://codereview.chromium.org/2389263007/diff/1/chrome/installer/linux/debian/build.sh File ...
4 years, 2 months ago (2016-10-06 18:49:21 UTC) #3
Tom (Use chromium acct)
lgtm % thestig@'s comments
4 years, 2 months ago (2016-10-06 19:33:01 UTC) #5
Tom (Use chromium acct)
Can we land this minus the stuff at chrome/installer/linux/debian/build.sh:170? I need it for a dependent ...
4 years, 2 months ago (2016-10-11 00:55:37 UTC) #6
Sam Clegg
On 2016/10/11 00:55:37, Tom Anderson wrote: > Can we land this minus the stuff at ...
4 years, 2 months ago (2016-10-11 18:32:12 UTC) #7
Tom (Use chromium acct)
On 2016/10/11 18:32:12, Sam Clegg wrote: > On 2016/10/11 00:55:37, Tom Anderson wrote: > > ...
4 years, 2 months ago (2016-10-11 18:36:52 UTC) #8
Sam Clegg
4 years, 2 months ago (2016-10-12 20:34:08 UTC) #10
Message was sent while issue was closed.
On 2016/10/11 18:36:52, Tom Anderson wrote:
> On 2016/10/11 18:32:12, Sam Clegg wrote:
> > On 2016/10/11 00:55:37, Tom Anderson wrote:
> > > Can we land this minus the stuff at
> > chrome/installer/linux/debian/build.sh:170?
> > > 
> > > I need it for a dependent patch set.
> > 
> > I would just clone the changes.  Does that work?   It doesn't make sense to
me
> > to add a new command line flag but then not use it anywhere.
> 
> Ok, that works

Closing in favor of https://codereview.chromium.org/2411423002/

Powered by Google App Engine
This is Rietveld 408576698