Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2389263005: [wasm] grow_memory(0) is the same as memory_size() (Closed)

Created:
4 years, 2 months ago by ahaas
Modified:
4 years, 2 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] grow_memory(0) is the same as memory_size() BUG=chromium:653264 TEST=cctest/test-run-wasm-module/GrowMemoryZero R=titzer@chromium.org Committed: https://crrev.com/a03ac68c55980016bda6e651f71d3ec763b4dd4d Cr-Commit-Position: refs/heads/master@{#40030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M src/wasm/wasm-module.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-module.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 2 months ago (2016-10-06 08:18:41 UTC) #1
titzer
On 2016/10/06 08:18:41, ahaas wrote: lgtm
4 years, 2 months ago (2016-10-06 11:40:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389263005/1
4 years, 2 months ago (2016-10-06 11:41:51 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 11:44:28 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 11:44:45 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a03ac68c55980016bda6e651f71d3ec763b4dd4d
Cr-Commit-Position: refs/heads/master@{#40030}

Powered by Google App Engine
This is Rietveld 408576698