Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2389263002: Fix stale WindowAndroid in PermissionUpdateInfoBarDelegate after reparenting. (Closed)

Created:
4 years, 2 months ago by Ted C
Modified:
4 years, 2 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org, dfalcantara+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix stale WindowAndroid in PermissionUpdateInfoBarDelegate after reparenting. BUG=640549 Committed: https://crrev.com/63a8719cc69e534a448495392182802679283c27 Cr-Commit-Position: refs/heads/master@{#422943}

Patch Set 1 #

Patch Set 2 : Handle null WindowAndroid #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/PermissionUpdateInfoBarDelegate.java View 1 5 chunks +21 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Ted C
PTAL
4 years, 2 months ago (2016-10-04 18:34:48 UTC) #2
gone
lgtm
4 years, 2 months ago (2016-10-04 20:11:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389263002/1
4 years, 2 months ago (2016-10-04 20:13:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2389263002/20001
4 years, 2 months ago (2016-10-04 20:33:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-04 21:41:12 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 21:44:12 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/63a8719cc69e534a448495392182802679283c27
Cr-Commit-Position: refs/heads/master@{#422943}

Powered by Google App Engine
This is Rietveld 408576698