| Index: third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
|
| diff --git a/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp b/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
|
| index 819a7133ac01d05cdb804f0701e649f21290abb5..c5b49731b83f203fcfec078abe6d8fdab4ff4427 100644
|
| --- a/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
|
| +++ b/third_party/WebKit/Source/modules/webaudio/BiquadDSPKernel.cpp
|
| @@ -31,9 +31,10 @@
|
|
|
| namespace blink {
|
|
|
| -// FIXME: As a recursive linear filter, depending on its parameters, a biquad filter can have
|
| -// an infinite tailTime. In practice, Biquad filters do not usually (except for very high resonance values)
|
| -// have a tailTime of longer than approx. 200ms. This value could possibly be calculated based on the
|
| +// FIXME: As a recursive linear filter, depending on its parameters, a biquad
|
| +// filter can have an infinite tailTime. In practice, Biquad filters do not
|
| +// usually (except for very high resonance values) have a tailTime of longer
|
| +// than approx. 200ms. This value could possibly be calculated based on the
|
| // settings of the Biquad.
|
| static const double MaxBiquadDelayTime = 0.2;
|
|
|
| @@ -84,7 +85,8 @@ void BiquadDSPKernel::updateCoefficients(int numberOfFrames,
|
| if (detune[k])
|
| normalizedFrequency *= pow(2, detune[k] / 1200);
|
|
|
| - // Configure the biquad with the new filter parameters for the appropriate type of filter.
|
| + // Configure the biquad with the new filter parameters for the appropriate
|
| + // type of filter.
|
| switch (getBiquadProcessor()->type()) {
|
| case BiquadProcessor::LowPass:
|
| m_biquad.setLowpassParams(k, normalizedFrequency, Q[k]);
|
| @@ -129,11 +131,13 @@ void BiquadDSPKernel::process(const float* source,
|
| DCHECK(getBiquadProcessor());
|
|
|
| // Recompute filter coefficients if any of the parameters have changed.
|
| - // FIXME: as an optimization, implement a way that a Biquad object can simply copy its internal filter coefficients from another Biquad object.
|
| - // Then re-factor this code to only run for the first BiquadDSPKernel of each BiquadProcessor.
|
| + // FIXME: as an optimization, implement a way that a Biquad object can simply
|
| + // copy its internal filter coefficients from another Biquad object. Then
|
| + // re-factor this code to only run for the first BiquadDSPKernel of each
|
| + // BiquadProcessor.
|
|
|
| - // The audio thread can't block on this lock; skip updating the coefficients for this block if
|
| - // necessary. We'll get them the next time around.
|
| + // The audio thread can't block on this lock; skip updating the coefficients
|
| + // for this block if necessary. We'll get them the next time around.
|
| {
|
| MutexTryLocker tryLocker(m_processLock);
|
| if (tryLocker.locked())
|
| @@ -167,16 +171,16 @@ void BiquadDSPKernel::getFrequencyResponse(int nFrequencies,
|
| float detune; // in Cents
|
|
|
| {
|
| - // Get a copy of the current biquad filter coefficients so we can update the biquad with
|
| - // these values. We need to synchronize with process() to prevent process() from updating
|
| - // the filter coefficients while we're trying to access them. The process will update it
|
| - // next time around.
|
| + // Get a copy of the current biquad filter coefficients so we can update the
|
| + // biquad with these values. We need to synchronize with process() to
|
| + // prevent process() from updating the filter coefficients while we're
|
| + // trying to access them. The process will update it next time around.
|
| //
|
| - // The BiquadDSPKernel object here (along with it's Biquad object) is for querying the
|
| - // frequency response and is NOT the same as the one in process() which is used for
|
| - // performing the actual filtering. This one is is created in
|
| - // BiquadProcessor::getFrequencyResponse for this purpose. Both, however, point to the same
|
| - // BiquadProcessor object.
|
| + // The BiquadDSPKernel object here (along with it's Biquad object) is for
|
| + // querying the frequency response and is NOT the same as the one in
|
| + // process() which is used for performing the actual filtering. This one is
|
| + // is created in BiquadProcessor::getFrequencyResponse for this purpose.
|
| + // Both, however, point to the same BiquadProcessor object.
|
| //
|
| // FIXME: Simplify this: crbug.com/390266
|
| MutexLocker processLocker(m_processLock);
|
|
|